Changeset 12518 in vbox

Timestamp:

Sep 16, 2008 9:47:36 PM (17 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

36667

Message:

r=bird: PDMSCSIREQUEST todos.

File:

• trunk/include/VBox/pdmifs.h (modified) (3 diffs)

trunk/include/VBox/pdmifs.h

@@ -2499 +2499 @@
     PDMSCSIREQUESTTXDIR_TO_DEVICE,
     PDMSCSIREQUESTTXDIR_NONE
+    /** @todo r=bird: 32-bit type size blowup? */
 } PDMSCSIREQUESTTXDIR;
 
@@ -2509 +2510 @@
     uint32_t    uLogicalUnit;
     /** Direction of the data flow. */
-    uint32_t    uDataDirection;
+    uint32_t    uDataDirection;         /**< @todo r=bird: why isn't this PDMSCSIREQUESTTXDIR? */
     /** Size of the SCSI CDB. */
     uint32_t    cbCDB;
     /** Pointer to the SCSI CDB. */
-    uint8_t    *paCDB;
+    uint8_t    *paCDB;                  /**< @todo r=bird: array what? pbCDB perhaps? */
     /** Overall size of all scatter gather list elements
      *  for data transfer if any. */
@@ -2525 +2526 @@
     /** Pointer to the sense buffer. *
      * Current assumption that the sense buffer is not scattered. */
-    uint8_t    *pu8SenseBuffer;
+    uint8_t    *pu8SenseBuffer;         /**< @todo r=bird: pbSenseBuffer is simpler */
     /** Opaque user data for use by the device. Left untouched by everything else! */
     void       *pvUser;