Changeset 1265 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Mar 6, 2007 12:37:24 PM (18 years ago)

Author:

vboxsync

Message:

FE/Qt: Fixed regressions that allowed to access the Settings dialog when a VM is in the Saved state.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/VBoxSelectorWnd.cpp (modified) (5 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/VBoxSelectorWnd.cpp

@@ -219 +219 @@
     void goToSettings();
     void sessionStateChanged (const VBoxSessionStateChangeEvent &aE);
+    void machineStateChanged (const VBoxMachineStateChangeEvent &aE);
 
 private:
@@ -268 +269 @@
 
     /* connect VirtualBox callback events */
+    connect (&vboxGlobal(), SIGNAL (machineStateChanged (const VBoxMachineStateChangeEvent &)),
+             this, SLOT (machineStateChanged (const VBoxSessionStateChangeEvent &)));
     connect (&vboxGlobal(), SIGNAL (sessionStateChanged (const VBoxSessionStateChangeEvent &)),
              this, SLOT (sessionStateChanged (const VBoxSessionStateChangeEvent &)));
@@ -298 +301 @@
         mBrowser->setPaper (backgroundBrush());
     }
+
+    /* check initial machine and session states */
+    bool saved = aMachine.GetState() == CEnums::Saved;
+    bool busy = aMachine.GetState() != CEnums::SessionClosed;
+    mBtnEdit->setEnabled (!saved && !busy);
 }
 
@@ -312 +320 @@
 }
 
-void VBoxVMDescriptionPage::sessionStateChanged (const VBoxSessionStateChangeEvent &aE)
-{
+void VBoxVMDescriptionPage::machineStateChanged (const VBoxMachineStateChangeEvent &aE)
+{
+    /// @todo this slot will not be necessary when we implement the selective
+    /// VM Settings dialog, where only fields that can be changed in the
+    /// saved state, can be changed.
+
     if (aE.id != mMachineId)
         return; /* not interested in other machines */
 
+    /* disable the edit button for a saved machine */
+    bool saved = aE.state == CEnums::Saved;
+    mBtnEdit->setEnabled (!saved);
+}
+
+void VBoxVMDescriptionPage::sessionStateChanged (const VBoxSessionStateChangeEvent &aE)
+{
+    if (aE.id != mMachineId)
+        return; /* not interested in other machines */
+
     /* whether another direct session is open or not */
     bool busy = aE.state != CEnums::SessionClosed;
-
     mBtnEdit->setEnabled (!busy);
 }
@@ -1062 +1083 @@
             vmDetailsView->setDetailsText (
                 vboxGlobal().detailsReport (m, false /* isNewVM */,
-                                               !running /* withLinks */));
+                                               modifyEnabled /* withLinks */));
         }
         if (aRefreshSnapshots)