Changeset 12652 in vbox for trunk/src/VBox/Frontends/VirtualBox4

Timestamp:

Sep 22, 2008 3:15:40 PM (17 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

36941

Message:

FE/Qt: ignore fake key release events generated by X11 when key repeat is active (when they can be detected without too much effort)

File:

• trunk/src/VBox/Frontends/VirtualBox4/src/VBoxConsoleView.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox4/src/VBoxConsoleView.cpp

@@ -1991 +1991 @@
         return true;
 
+    /* When X11 sends events for repeated keys, it always inserts an
+     * XKeyRelease before the XKeyPress.  Since it nearly always
+     * (always?) uses the same time stamp for both, we can spot the
+     * unwanted event and discard it.  Of course, if we do miss one it
+     * isn't fatal for our purposes. */
+    if ((XKeyRelease == event->type) && XPending(event->xkey.display))
+    {
+        XEvent nextEvent;
+
+        XPeekEvent(event->xkey.display, &nextEvent);
+        if ((XKeyPress == nextEvent.type) &&
+            (event->xkey.keycode == nextEvent.xkey.keycode) &&
+            (event->xkey.time == nextEvent.xkey.time))
+            /* Discard it, don't pass it to Qt. */
+            return true;
+    }
+
     KeySym ks = ::XKeycodeToKeysym (event->xkey.display, event->xkey.keycode, 0);