Changeset 12672 in vbox for trunk/src/VBox/HostDrivers

Timestamp:

Sep 23, 2008 1:52:50 PM (16 years ago)

Author:

vboxsync

Message:

Solaris/vboxnetflt: per-queue locking.

File:

• trunk/src/VBox/HostDrivers/VBoxNetFlt/solaris/VBoxNetFlt-solaris.c (modified) (4 diffs)

trunk/src/VBox/HostDrivers/VBoxNetFlt/solaris/VBoxNetFlt-solaris.c

@@ -194 +194 @@
     ddi_prop_op,                    /* property ops */
     &g_VBoxNetFltSolarisStreamTab,
-    D_NEW | D_MP | D_MTQPAIR,       /* compat. flag */
+    D_NEW | D_MP | D_MTPERQ,        /* compat. flag */
     CB_REV                          /* revision */
 };
@@ -725 +725 @@
     *ppPrevStream = pStream;
 
+    RTSpinlockRelease(pThis->hSpinlock, &Tmp);
     qprocson(pQueue);
 
+    /*
+     * Don't hold the spinlocks across putnext calls as it could
+     * (and does mostly) re-enter the put procedure on the same thread.
+     */
     if (pStream->Type == kPromiscStream)
     {
@@ -759 +764 @@
         else
             LogRel((DEVICE_NAME ":vboxNetFltSolarisBindReq failed rc=%Vrc.\n", rc));
-
-        if (RT_FAILURE(rc))
-        {
-            RTSpinlockRelease(pThis->hSpinlock, &Tmp);
-            return EPROTO;
-        }
     }
 
@@ -772 +771 @@
     LogFlow((DEVICE_NAME ":VBoxNetFltSolarisModOpen returns 0, DevMinor=%d pQueue=%p\n", DevMinor, pStream->pReadQueue));
 
-    RTSpinlockRelease(pThis->hSpinlock, &Tmp);
     return 0;
 }