Changeset 12939 in vbox for trunk/src/VBox/Devices/PC

Timestamp:

Oct 2, 2008 2:20:24 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

37364

Message:

refined APIC writes a bit, put a comment with explanation where bad writes can come from

File:

• trunk/src/VBox/Devices/PC/DevAPIC.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/PC/DevAPIC.cpp

@@ -1567 +1567 @@
                         /* According to IOAPIC spec, vectors should be from 0x10 to 0xfe */
                         uint8_t vec = val & 0xff;
-                        if ((vec >= 0x10) && (vec < 0xff))
+                        if ((val & APIC_LVT_MASKED) ||
+                            ((vec >= 0x10) && (vec < 0xff)))
                         {
                             s->ioredtbl[index] &= ~0xffffffffULL;
@@ -1574 +1575 @@
                         else
                         {
-                            LogRel(("IOAPIC BUG: bad vector writing %x(sel=%x) to %d\n", val, s->ioregsel, index));
+                            /*
+                             * Linux 2.6 kernels has pretty strange function 
+                             * unlock_ExtINT_logic() which writes
+                             * absolutely bogus (all 0) value into the vector
+                             * with pretty vague explanation why.
+                             * So we just ignore such writes.
+                             */
+                            LogRel(("IOAPIC GUEST BUG: bad vector writing %x(sel=%x) to %d\n", val, s->ioregsel, index));
                         }
                     }