Changeset 12997 in vbox for trunk/src/VBox/VMM/VMMAll

Timestamp:

Oct 6, 2008 9:31:20 AM (16 years ago)

Author:

vboxsync

Message:

Fixed regressions in return code checking

File:

• trunk/src/VBox/VMM/VMMAll/PGMAllBth.h (modified) (3 diffs)

trunk/src/VBox/VMM/VMMAll/PGMAllBth.h

@@ -162 +162 @@
 
     rc = PGMShwSyncLongModePDPtr(pVM, (RTGCUINTPTR)pvFault, pPml4eSrc, &PdpeSrc, &pPDDst);
-    AssertRCReturn(rc, rc);
+    AssertReturn(rc == VINF_SUCCESS /* *must* test for VINF_SUCCESS!! */, rc);
     Assert(pPDDst);
 # elif PGM_SHW_TYPE == PGM_TYPE_EPT
@@ -2838 +2838 @@
 
         int rc = PGMShwSyncLongModePDPtr(pVM, GCPtrPage, pPml4eSrc, &PdpeSrc, &pPDDst);
-        if (rc != VINF_SUCCESS)
-        {
-            AssertRC(rc);
-            return rc;
-        }
+        AssertReturn(rc == VINF_SUCCESS /* *must* test for VINF_SUCCESS!! */, rc);
         Assert(pPDDst);
         PdeDst = pPDDst->a[iPDDst];
@@ -2957 +2953 @@
 
     rc = PGMShwSyncLongModePDPtr(pVM, GCPtrPage, pPml4eSrc, &PdpeSrc, &pPDDst);
-    if (rc != VINF_SUCCESS)
-    {
-        AssertRC(rc);
-        return rc;
-    }
+    AssertReturn(rc == VINF_SUCCESS /* *must* test for VINF_SUCCESS!! */, rc);
     Assert(pPDDst);
     pPdeDst = &pPDDst->a[iPDDst];