Changeset 13201 in vbox

Timestamp:

Oct 13, 2008 9:35:40 AM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

37744

Message:

Could return uninitialized variable in the bridging case

File:

• trunk/src/VBox/Devices/Bus/DevPCI.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Bus/DevPCI.cpp

@@ -523 +523 @@
     uint8_t iBus, iDevice;
     uint32_t config_addr;
-    uint32_t val;
+    uint32_t val = 0xffffffff;
 
     if (!(pGlobals->uConfigReg & (1 << 31)))
-        goto fail;
+        goto the_end;
     if ((pGlobals->uConfigReg & 0x3) != 0)
-        goto fail;
+        goto the_end;
     iBus = (pGlobals->uConfigReg >> 16) & 0xff;
     iDevice = (pGlobals->uConfigReg >> 8) & 0xff;
@@ -566 +566 @@
         pci_dev = pGlobals->PciBus.devices[iDevice];
         if (!pci_dev) {
-        fail:
-            switch(len) {
-            case 1:
-                val = 0xff;
-                break;
-            case 2:
-                val = 0xffff;
-                break;
-            default:
-            case 4:
-                val = 0xffffffff;
-                break;
-            }
             goto the_end;
         }