Changeset 13213 in vbox for trunk

Timestamp:

Oct 13, 2008 12:38:07 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

37761

Message:

iprt/timer-posix.cpp: Don't access private siginfo members, that's not portable. (We don't set fSuspended non-atomically because of access consistency.)

File:

• trunk/src/VBox/Runtime/r3/posix/timer-posix.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/r3/posix/timer-posix.cpp

@@ -373 +373 @@
         if (RT_LIKELY(sigwaitinfo(&SigSet, &SigInfo) >= 0))
         {
-            LogFlow(("rttimerThread: signo=%d pTimer=%p\n", SigInfo.si_signo, SigInfo._sifields._timer.si_sigval.sival_ptr));
+            LogFlow(("rttimerThread: signo=%d pTimer=%p\n", SigInfo.si_signo, SigInfo.si_value.sival_ptr));
             if (RT_LIKELY(   SigInfo.si_signo == RT_TIMER_SIGNAL
                           && SigInfo.si_code == SI_TIMER)) /* The SI_TIMER check is *essential* because of the pthread_kill. */
             {
-                PRTTIMER pTimer = (PRTTIMER)SigInfo._sifields._timer.si_sigval.sival_ptr;
+                PRTTIMER pTimer = (PRTTIMER)SigInfo.si_value.sival_ptr;
                 AssertPtr(pTimer);
                 if (RT_UNLIKELY(    !VALID_PTR(pTimer)
@@ -389 +389 @@
                 /* auto suspend one-shot timers. */
                 if (RT_UNLIKELY(!pTimer->u64NanoInterval))
-                    ASMAtomicWriteU8(&pTimer->fSuspended, true); /** @todo Can't we do a simple assigment here? */
+                    ASMAtomicWriteU8(&pTimer->fSuspended, true);
             }
         }