Changeset 13271 in vbox for trunk/src/VBox/HostDrivers/Support

Timestamp:

Oct 15, 2008 12:18:57 AM (16 years ago)

Author:

vboxsync

Message:

SUPDrv: Disable interrupts when executing supdrvGipUpdate/PerCpu on all platforms. This assumes RTMpCpuId and RtMpTimeSystemNanoTS are safe.

File:

• trunk/src/VBox/HostDrivers/Support/SUPDrv.c (modified) (3 diffs)

trunk/src/VBox/HostDrivers/Support/SUPDrv.c

@@ -4591 +4591 @@
 static DECLCALLBACK(void) supdrvGipSyncTimer(PRTTIMER pTimer, void *pvUser, uint64_t iTick)
 {
-#ifdef RT_OS_SOLARIS
-    RTCCUINTREG     fOldFlags = ASMIntDisableFlags(); /* brute force for S10. */
-#endif
+    RTCCUINTREG     fOldFlags = ASMIntDisableFlags(); /* No interruptions please (real problem on S10). */
     PSUPDRVDEVEXT   pDevExt   = (PSUPDRVDEVEXT)pvUser;
+
     supdrvGipUpdate(pDevExt->pGip, RTTimeSystemNanoTS());
 
-#ifdef RT_OS_SOLARIS
     ASMSetFlags(fOldFlags);
-#endif
 }
 
@@ -4610 +4607 @@
 static DECLCALLBACK(void) supdrvGipAsyncTimer(PRTTIMER pTimer, void *pvUser, uint64_t iTick)
 {
-#ifdef RT_OS_SOLARIS
-    RTCCUINTREG     fOldFlags = ASMIntDisableFlags(); /* brute force for S10. */
-#endif
+    RTCCUINTREG     fOldFlags = ASMIntDisableFlags(); /* No interruptions please (real problem on S10). */
     PSUPDRVDEVEXT   pDevExt   = (PSUPDRVDEVEXT)pvUser;
     RTCPUID         idCpu     = RTMpCpuId();
@@ -4623 +4618 @@
         supdrvGipUpdatePerCpu(pDevExt->pGip, NanoTS, ASMGetApicId());
 
-#ifdef RT_OS_SOLARIS
     ASMSetFlags(fOldFlags);
-#endif
 }