Changeset 13387 in vbox for trunk/src

Timestamp:

Oct 20, 2008 11:42:28 AM (16 years ago)

Author:

vboxsync

Message:

First sketch of functionality to create guest physical address aliases.

Location:

trunk/src/VBox/VMM/VMMAll

Files:

• IOMAllMMIO.cpp (modified) (16 diffs)
• PGMAllHandler.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMAll/IOMAllMMIO.cpp

@@ -35 +35 @@
 #include "IOMInternal.h"
 #include <VBox/vm.h>
+#include <VBox/hwaccm.h>
 
 #include <VBox/dis.h>
@@ -167 +168 @@
  * @returns VBox status code.
  *
- * @param   pVM         The virtual machine (GC pointer ofcourse).
+ * @param   pVM         The virtual machine.
  * @param   pRegFrame   Pointer to CPUMCTXCORE guest registers structure.
  * @param   pCpu        Disassembler CPU state.
@@ -226 +227 @@
  * @returns VBox status code.
  *
- * @param   pVM         The virtual machine (GC pointer ofcourse).
+ * @param   pVM         The virtual machine.
  * @param   pRegFrame   Pointer to CPUMCTXCORE guest registers structure.
  * @param   pCpu        Disassembler CPU state.
@@ -285 +286 @@
  * @returns VBox status code.
  *
- * @param   pVM         The virtual machine (GC pointer ofcourse).
+ * @param   pVM         The virtual machine.
  * @param   uErrorCode  CPU Error code.
  * @param   pRegFrame   Trap register frame.
@@ -518 +519 @@
  * @returns VBox status code.
  *
- * @param   pVM         The virtual machine (GC pointer ofcourse).
+ * @param   pVM         The virtual machine .
  * @param   pRegFrame   Trap register frame.
  * @param   GCPhysFault The GC physical address corresponding to pvFault.
@@ -644 +645 @@
  * @returns VBox status code.
  *
- * @param   pVM         The virtual machine (GC pointer ofcourse).
+ * @param   pVM         The virtual machine.
  * @param   pRegFrame   Trap register frame.
  * @param   GCPhysFault The GC physical address corresponding to pvFault.
@@ -692 +693 @@
  * @returns VBox status code.
  *
- * @param   pVM         The virtual machine (GC pointer ofcourse).
+ * @param   pVM         The virtual machine.
  * @param   pRegFrame   Trap register frame.
  * @param   GCPhysFault The GC physical address corresponding to pvFault.
@@ -745 +746 @@
  * @returns VBox status code.
  *
- * @param   pVM         The virtual machine (GC pointer ofcourse).
+ * @param   pVM         The virtual machine.
  * @param   pRegFrame   Trap register frame.
  * @param   GCPhysFault The GC physical address corresponding to pvFault.
@@ -834 +835 @@
  * @returns VBox status code.
  *
- * @param   pVM         The virtual machine (GC pointer ofcourse).
+ * @param   pVM         The virtual machine.
  * @param   pRegFrame   Trap register frame.
  * @param   GCPhysFault The GC physical address corresponding to pvFault.
@@ -886 +887 @@
  * @returns VBox status code.
  *
- * @param   pVM         The virtual machine (GC pointer ofcourse).
+ * @param   pVM         The virtual machine.
  * @param   pRegFrame   Trap register frame.
  * @param   GCPhysFault The GC physical address corresponding to pvFault.
@@ -936 +937 @@
  * @returns VBox status code.
  *
- * @param   pVM         The virtual machine (GC pointer ofcourse).
+ * @param   pVM         The virtual machine.
  * @param   pRegFrame   Trap register frame.
  * @param   GCPhysFault The GC physical address corresponding to pvFault.
@@ -1416 +1417 @@
  * @retval  VINF_EM_RESCHEDULE_REM      The exception was dispatched and cannot be executed in raw-mode. (TRPMRaiseXcptErr)
  *
- * @param   pVM             The virtual machine (GC pointer ofcourse).
+ * @param   pVM             The virtual machine.
  * @param   pRegFrame       Pointer to CPUMCTXCORE guest registers structure.
  * @param   uPort           IO Port
@@ -1533 +1534 @@
  * @retval  VINF_EM_RESCHEDULE_REM      The exception was dispatched and cannot be executed in raw-mode. (TRPMRaiseXcptErr)
  *
- * @param   pVM         The virtual machine (GC pointer ofcourse).
+ * @param   pVM         The virtual machine.
  * @param   pRegFrame   Pointer to CPUMCTXCORE guest registers structure.
  * @param   pCpu        Disassembler CPU state.
@@ -1577 +1578 @@
  * @retval  VINF_EM_RESCHEDULE_REM      The exception was dispatched and cannot be executed in raw-mode. (TRPMRaiseXcptErr)
  *
- * @param   pVM             The virtual machine (GC pointer ofcourse).
+ * @param   pVM             The virtual machine.
  * @param   pRegFrame       Pointer to CPUMCTXCORE guest registers structure.
  * @param   uPort           IO Port
@@ -1696 +1697 @@
  * @retval  VINF_EM_RESCHEDULE_REM      The exception was dispatched and cannot be executed in raw-mode. (TRPMRaiseXcptErr)
  *
- * @param   pVM         The virtual machine (GC pointer ofcourse).
+ * @param   pVM         The virtual machine.
  * @param   pRegFrame   Pointer to CPUMCTXCORE guest registers structure.
  * @param   pCpu        Disassembler CPU state.
@@ -1725 +1726 @@
 }
 
+#ifdef IN_RING0
+/**
+ * Modify an existing MMIO region page; map to another guest physical region and change the access flags
+ *
+ * @returns VBox status code. 
+ *
+ * @param   pVM             The virtual machine.
+ * @param   GCPhys          Physical address that's part of the MMIO region to be changed.
+ * @param   GCPhysRemapped  Remapped address.
+ * @param   fPageFlags      Page flags to set (typically X86_PTE_RW).
+ */
+VMMDECL(int)  IOMMMIOModifyPage(PVM pVM, RTGCPHYS GCPhys, RTGCPHYS GCPhysRemapped, uint64_t fPageFlags)
+{
+    Assert(fPageFlags == X86_PTE_RW);
+
+    Log(("IOMMMIOModifyPage %VGp -> %VGp flags=%RX64\n", GCPhys, GCPhysRemapped, fPageFlags));
+
+    /*
+     * Lookup the current context range node and statistics.
+     */
+    PIOMMMIORANGE pRange = iomMMIOGetRange(&pVM->iom.s, GCPhys);
+    AssertMsgReturn(pRange,
+                    ("Handlers and page tables are out of sync or something! GCPhys=%VGp\n", GCPhys),
+                    VERR_INTERNAL_ERROR);
+
+    GCPhys         &= 0xfff;
+    GCPhysRemapped &= 0xfff;
+
+    /* This currently only works in real mode, protected mode without paging or with nested paging. */
+    if (    CPUMIsGuestInPagedProtectedMode(pVM)
+        && !HWACCMIsNestedPagingActive(pVM))
+        return VINF_SUCCESS;    /* ignore */
+
+    int rc = PGMHandlerPhysicalPageAlias(pVM, pRange->GCPhys, GCPhys, GCPhysRemapped);
+    AssertRCReturn(rc, rc);
+
+    /* Mark it as writable and present so reads and writes no longer fault. */
+    rc = PGMShwSetPage(pVM, (RTGCPTR)GCPhys, PAGE_SIZE, X86_PTE_RW | X86_PTE_P);
+    AssertRC(rc);
+
+    return VINF_SUCCESS;
+}
+
+/**
+ * Reset a previously modified MMIO region; restore the access flags.
+ *
+ * @returns VBox status code. 
+ *
+ * @param   pVM             The virtual machine.
+ * @param   GCPhys          Physical address that's part of the MMIO region to be reset.
+ */
+VMMDECL(int)  IOMMMIOResetRegion(PVM pVM, RTGCPHYS GCPhys)
+{
+    unsigned cb;
+
+    Log(("IOMMMIOResetRegion %VGp\n", GCPhys));
+    /*
+     * Lookup the current context range node and statistics.
+     */
+    PIOMMMIORANGE pRange = iomMMIOGetRange(&pVM->iom.s, GCPhys);
+    AssertMsgReturn(pRange,
+                    ("Handlers and page tables are out of sync or something! GCPhys=%VGp\n", GCPhys),
+                    VERR_INTERNAL_ERROR);
+
+    /* This currently only works in real mode, protected mode without paging or with nested paging. */
+    if (    CPUMIsGuestInPagedProtectedMode(pVM)
+        && !HWACCMIsNestedPagingActive(pVM))
+        return VINF_SUCCESS;    /* ignore */
+
+
+    cb     = pRange->cb;
+    GCPhys = pRange->GCPhys;
+
+    while(cb)
+    {
+        int rc = PGMHandlerPhysicalPageReset(pVM, pRange->GCPhys, GCPhys);
+        AssertRC(rc);
+
+        /* Mark it as not present again to intercept all read and write access. */
+        rc = PGMShwSetPage(pVM, (RTGCPTR)GCPhys, PAGE_SIZE, 0);
+        AssertRC(rc);
+
+        cb     -= PAGE_SIZE;
+        GCPhys += PAGE_SIZE;
+    }
+    return VINF_SUCCESS;
+}
+#endif

trunk/src/VBox/VMM/VMMAll/PGMAllHandler.cpp

@@ -884 +884 @@
             AssertRCReturn(rc, rc);
             PGM_PAGE_SET_HNDL_PHYS_STATE(pPage, PGM_PAGE_HNDL_PHYS_STATE_DISABLED);
-#ifdef IN_RING0
+#ifndef IN_GC
+            HWACCMInvalidatePhysPage(pVM, GCPhysPage);
+#endif
+            return VINF_SUCCESS;
+        }
+
+        AssertMsgFailed(("The page %#x is outside the range %#x-%#x\n",
+                         GCPhysPage, pCur->Core.Key, pCur->Core.KeyLast));
+        return VERR_INVALID_PARAMETER;
+    }
+
+    AssertMsgFailed(("Specified physical handler start address %#x is invalid.\n", GCPhys));
+    return VERR_PGM_HANDLER_NOT_FOUND;
+}
+
+/**
+ * Temporarily turns off the access monitoring of a page within an MMIO
+ * access handler region and remaps it to another guest physical region.
+ *
+ * Use this when no further \#PFs are required for that page. Be aware that
+ * a page directory sync might reset the flags, and turn on access monitoring
+ * for the page.
+ *
+ * The caller must do required page table modifications.
+ *
+ * @returns VBox status code.
+ * @param   pVM                 VM Handle
+ * @param   GCPhys              Start physical address earlier passed to PGMR3HandlerPhysicalRegister().
+ *                              This must be a fully page aligned range or we risk messing up other
+ *                              handlers installed for the start and end pages.
+ * @param   GCPhysPage          Physical address of the page to turn off access monitoring for.
+ * @param   GCPhysPageRemap     Physical address of the page that serves as backing memory.
+ */
+VMMDECL(int)  PGMHandlerPhysicalPageAlias(PVM pVM, RTGCPHYS GCPhys, RTGCPHYS GCPhysPage, RTGCPHYS GCPhysPageRemap)
+{
+    /*
+     * Validate the range.
+     */
+    PPGMPHYSHANDLER pCur = (PPGMPHYSHANDLER)RTAvlroGCPhysGet(&pVM->pgm.s.CTX_SUFF(pTrees)->PhysHandlers, GCPhys);
+    if (RT_LIKELY(pCur))
+    {
+        if (RT_LIKELY(    GCPhysPage >= pCur->Core.Key
+                      &&  GCPhysPage <= pCur->Core.KeyLast))
+        {
+            Assert(!(pCur->Core.Key & PAGE_OFFSET_MASK));
+            Assert((pCur->Core.KeyLast & PAGE_OFFSET_MASK) == PAGE_OFFSET_MASK);
+
+            AssertReturn(pCur->enmType == PGMPHYSHANDLERTYPE_MMIO, VERR_ACCESS_DENIED);
+
+            PPGMPAGE pPageRemap;
+            int rc = pgmPhysGetPageEx(&pVM->pgm.s, GCPhysPageRemap, &pPageRemap);
+            AssertRCReturn(rc, rc);
+
+            /*
+             * Change the page status.
+             */
+            PPGMPAGE pPage;
+            rc = pgmPhysGetPageEx(&pVM->pgm.s, GCPhysPage, &pPage);
+            AssertRCReturn(rc, rc);
+
+            /* Do the actual remapping here. This page now serves as an alias for the backing memory specified. */
+            pPage->HCPhys = pPageRemap->HCPhys;
+
+            PGM_PAGE_SET_HNDL_PHYS_STATE(pPage, PGM_PAGE_HNDL_PHYS_STATE_DISABLED);
+#ifndef IN_GC
             HWACCMInvalidatePhysPage(pVM, GCPhysPage);
 #endif
@@ -928 +992 @@
 
             AssertReturn(   pCur->enmType == PGMPHYSHANDLERTYPE_PHYSICAL_WRITE
-                         || pCur->enmType == PGMPHYSHANDLERTYPE_PHYSICAL_ALL,
+                         || pCur->enmType == PGMPHYSHANDLERTYPE_PHYSICAL_ALL
+                         || pCur->enmType == PGMPHYSHANDLERTYPE_MMIO,
                          VERR_ACCESS_DENIED);
 
@@ -938 +1003 @@
             AssertRCReturn(rc, rc);
             PGM_PAGE_SET_HNDL_PHYS_STATE(pPage, pgmHandlerPhysicalCalcState(pCur));
+#ifndef IN_GC
+            HWACCMInvalidatePhysPage(pVM, GCPhysPage);
+#endif
             return VINF_SUCCESS;
         }