Changeset 13556 in vbox for trunk/src/VBox/Main/ConsoleImpl.cpp

Timestamp:

Oct 24, 2008 2:17:17 PM (16 years ago)

Author:

vboxsync

Message:

Guest Properties (Main, HostServices, VBoxGuestLib): MAX_*_LEN is the size in bytes, not the string length

File:

• trunk/src/VBox/Main/ConsoleImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/ConsoleImpl.cpp

@@ -3513 +3513 @@
     Utf8Str Utf8Name = aName;
     AssertReturn(!Utf8Name.isNull(), E_OUTOFMEMORY);
-    char pszBuffer[MAX_VALUE_LEN + MAX_FLAGS_LEN + 2];
+    char pszBuffer[MAX_VALUE_LEN + MAX_FLAGS_LEN];
 
     parm[0].type = VBOX_HGCM_SVC_PARM_PTR;
@@ -4594 +4594 @@
          pValue = CFGMR3GetNextValue (pValue))
     {
-        char szPropName[guestProp::MAX_NAME_LEN + 1];
+        char szPropName[guestProp::MAX_NAME_LEN];
         vrc = CFGMR3GetValueName (pValue, szPropName, sizeof(szPropName));
         if (RT_SUCCESS(vrc))
@@ -4620 +4620 @@
         using namespace guestProp;
 
-        char szPropName [MAX_NAME_LEN + 1];
-        char szPropValue [MAX_VALUE_LEN + 1];
-        char szPropFlags [MAX_FLAGS_LEN + 1];
+        char szPropName [MAX_NAME_LEN];
+        char szPropValue [MAX_VALUE_LEN];
+        char szPropFlags [MAX_FLAGS_LEN];
         ULONG64 u64Timestamp = 0;  /* default */
         vrc = CFGMR3GetValueName (pValue, szPropName, sizeof (szPropName));