Changeset 13586 in vbox

Timestamp:

Oct 27, 2008 4:33:51 PM (17 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

38493

Message:

TM: extended the statistics to get an idea about the normal catchup rate.

Location:

trunk/src/VBox/VMM

Files:

• TM.cpp (modified) (1 diff)
• TMInternal.h (modified) (1 diff)
• VMMAll/TMAllCpu.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/TM.cpp

@@ -538 +538 @@
     STAM_REG(pVM, &pVM->tm.s.StatTimerCallbackSetFF,STAMTYPE_COUNTER,       "/TM/CallbackSetFF",    STAMUNIT_OCCURENCES,        "The number of times the timer callback set FF.");
 
-    STAM_REG(pVM, &pVM->tm.s.StatTSCNotFixed,       STAMTYPE_COUNTER,       "/TM/TSC/Intercept/NotFixed",         STAMUNIT_OCCURENCES,        "The number of times TMCpuTickCanUseRealTSC forced rdtsc intercept.");
-    STAM_REG(pVM, &pVM->tm.s.StatTSCNotTicking,     STAMTYPE_COUNTER,       "/TM/TSC/Intercept/NotTicking",       STAMUNIT_OCCURENCES,        "The number of times TMCpuTickCanUseRealTSC forced rdtsc intercept.");
-    STAM_REG(pVM, &pVM->tm.s.StatTSCCatchup,        STAMTYPE_COUNTER,       "/TM/TSC/Intercept/Catchup",          STAMUNIT_OCCURENCES,        "The number of times TMCpuTickCanUseRealTSC forced rdtsc intercept.");
-    STAM_REG(pVM, &pVM->tm.s.StatTSCWarp,           STAMTYPE_COUNTER,       "/TM/TSC/Intercept/Warp",             STAMUNIT_OCCURENCES,        "The number of times TMCpuTickCanUseRealTSC forced rdtsc intercept.");
-    STAM_REG(pVM, &pVM->tm.s.StatTSCSyncNotTicking, STAMTYPE_COUNTER,       "/TM/TSC/Intercept/SyncNotTicking",       STAMUNIT_OCCURENCES,        "The number of times TMCpuTickCanUseRealTSC forced rdtsc intercept.");
+    STAM_REG(pVM, &pVM->tm.s.StatTSCCatchupLE010,   STAMTYPE_COUNTER,       "/TM/TSC/Intercept/CatchupLE010",     STAMUNIT_OCCURENCES,        "In catch-up mode, 10% or lower.");
+    STAM_REG(pVM, &pVM->tm.s.StatTSCCatchupLE025,   STAMTYPE_COUNTER,       "/TM/TSC/Intercept/CatchupLE025",     STAMUNIT_OCCURENCES,        "In catch-up mode, 25%-11%.");
+    STAM_REG(pVM, &pVM->tm.s.StatTSCCatchupLE100,   STAMTYPE_COUNTER,       "/TM/TSC/Intercept/CatchupLE100",     STAMUNIT_OCCURENCES,        "In catch-up mode, 100%-26%.");
+    STAM_REG(pVM, &pVM->tm.s.StatTSCCatchupOther,   STAMTYPE_COUNTER,       "/TM/TSC/Intercept/CatchupOther",     STAMUNIT_OCCURENCES,        "In catch-up mode, > 100%.");
+    STAM_REG(pVM, &pVM->tm.s.StatTSCNotFixed,       STAMTYPE_COUNTER,       "/TM/TSC/Intercept/NotFixed",         STAMUNIT_OCCURENCES,        "TSC is not fixed, it may run at variable speed.");
+    STAM_REG(pVM, &pVM->tm.s.StatTSCNotTicking,     STAMTYPE_COUNTER,       "/TM/TSC/Intercept/NotTicking",       STAMUNIT_OCCURENCES,        "TSC is not ticking.");
+    STAM_REG(pVM, &pVM->tm.s.StatTSCSyncNotTicking, STAMTYPE_COUNTER,       "/TM/TSC/Intercept/SyncNotTicking",   STAMUNIT_OCCURENCES,        "VirtualSync isn't ticking.");
+    STAM_REG(pVM, &pVM->tm.s.StatTSCWarp,           STAMTYPE_COUNTER,       "/TM/TSC/Intercept/Warp",             STAMUNIT_OCCURENCES,        "Warpdrive is active.");
 
 

trunk/src/VBox/VMM/TMInternal.h

@@ -488 +488 @@
     STAMCOUNTER                 StatTimerCallbackSetFF;
 
-
+    /** @name Reasons for refusing TSC offsetting in TMCpuTickCanUseRealTSC.
+     * @{ */
     STAMCOUNTER                 StatTSCNotFixed;
     STAMCOUNTER                 StatTSCNotTicking;
-    STAMCOUNTER                 StatTSCCatchup;
+    STAMCOUNTER                 StatTSCCatchupLE010;
+    STAMCOUNTER                 StatTSCCatchupLE025;
+    STAMCOUNTER                 StatTSCCatchupLE100;
+    STAMCOUNTER                 StatTSCCatchupOther;
     STAMCOUNTER                 StatTSCWarp;
     STAMCOUNTER                 StatTSCSyncNotTicking;
+    /** @} */
 } TM;
 /** Pointer to TM VM instance data. */

trunk/src/VBox/VMM/VMMAll/TMAllCpu.cpp

@@ -148 +148 @@
      *          c) we're not using warp drive (accelerated virtual guest time).
      */
-#ifdef VBOX_WITH_STATISTICS
-    if (!pVM->tm.s.fMaybeUseOffsettedHostTSC)
-       STAM_COUNTER_INC(&pVM->tm.s.StatTSCNotFixed);
-    else
-    if (!pVM->tm.s.fTSCTicking)
-       STAM_COUNTER_INC(&pVM->tm.s.StatTSCNotTicking);
-    else
-    if (!pVM->tm.s.fTSCUseRealTSC)
-    {
-        if (pVM->tm.s.fVirtualSyncCatchUp)
-           STAM_COUNTER_INC(&pVM->tm.s.StatTSCCatchup);
-        else
-        if (!pVM->tm.s.fVirtualSyncTicking)
-           STAM_COUNTER_INC(&pVM->tm.s.StatTSCSyncNotTicking);
-        else
-        if (!pVM->tm.s.fVirtualWarpDrive)
-           STAM_COUNTER_INC(&pVM->tm.s.StatTSCWarp);
-    }
-#endif
-
     if (    pVM->tm.s.fMaybeUseOffsettedHostTSC
         &&  RT_LIKELY(pVM->tm.s.fTSCTicking)
@@ -200 +180 @@
                 *poffRealTSC = 0;
         }
+        /** @todo count this? */
         return true;
     }
 
+#ifdef VBOX_WITH_STATISTICS
+    /* Sample the reason for refusing. */
+    if (!pVM->tm.s.fMaybeUseOffsettedHostTSC)
+       STAM_COUNTER_INC(&pVM->tm.s.StatTSCNotFixed);
+    else if (!pVM->tm.s.fTSCTicking)
+       STAM_COUNTER_INC(&pVM->tm.s.StatTSCNotTicking);
+    else if (!pVM->tm.s.fTSCUseRealTSC)
+    {
+        if (pVM->tm.s.fVirtualSyncCatchUp)
+        {
+           if (pVM->tm.s.u32VirtualSyncCatchUpPercentage <= 10)
+               STAM_COUNTER_INC(&pVM->tm.s.StatTSCCatchupLE010);
+           else if (pVM->tm.s.u32VirtualSyncCatchUpPercentage <= 25)
+               STAM_COUNTER_INC(&pVM->tm.s.StatTSCCatchupLE025);
+           else if (pVM->tm.s.u32VirtualSyncCatchUpPercentage <= 100)
+               STAM_COUNTER_INC(&pVM->tm.s.StatTSCCatchupLE100);
+           else
+               STAM_COUNTER_INC(&pVM->tm.s.StatTSCCatchupOther);
+        }
+        else if (!pVM->tm.s.fVirtualSyncTicking)
+           STAM_COUNTER_INC(&pVM->tm.s.StatTSCSyncNotTicking);
+        else if (pVM->tm.s.fVirtualWarpDrive)
+           STAM_COUNTER_INC(&pVM->tm.s.StatTSCWarp);
+    }
+#endif
     return false;
 }