Changeset 13672 in vbox for trunk/src/recompiler_new/target-i386

Timestamp:

Oct 30, 2008 12:09:07 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

38627

Message:

improved external events check performance, synced couple VBOX-specific
recompiler checks

File:

• trunk/src/recompiler_new/target-i386/translate.c (modified) (4 diffs)

trunk/src/recompiler_new/target-i386/translate.c

@@ -817 +817 @@
 #endif /* VBOX */
 {
-#ifdef VBOX
-    gen_check_external_event();
-#endif /* VBOX */
     tcg_gen_movi_tl(cpu_tmp0, pc);
     tcg_gen_st_tl(cpu_tmp0, cpu_env, offsetof(CPUState, eip));
@@ -827 +824 @@
 static void gen_check_external_event()
 {
-#if 0
-    /** @todo: nike make it work */
-    /* This code is more effective, but for whatever reason TCG fails to compile it */
     int skip_label;
     TCGv t0;
     
     skip_label = gen_new_label();
-    t0 = tcg_temp_local_new(TCG_TYPE_TL);
-    /* t0 = cpu_tmp0; */
+    /* t0 = tcg_temp_local_new(TCG_TYPE_TL); */
+    t0 = cpu_tmp0; 
 
     tcg_gen_ld32u_tl(t0, cpu_env, offsetof(CPUState, interrupt_request));
@@ -844 +838 @@
                     | CPU_INTERRUPT_EXTERNAL_DMA
                     | CPU_INTERRUPT_EXTERNAL_HARD);
-    tcg_gen_brcond_i32(TCG_COND_EQ, t0, 0, skip_label);
-    tcg_temp_free(t0);
+    /** @todo: predict branch as taken */
+    tcg_gen_brcondi_i32(TCG_COND_EQ, t0, 0, skip_label);
+    /* tcg_temp_free(t0); */
 
     tcg_gen_helper_0_0(helper_check_external_event);
 
    gen_set_label(skip_label);
-#else
-    tcg_gen_helper_0_0(helper_check_external_event);
-#endif
 }
 
@@ -7867 +7859 @@
             mod = (modrm >> 6) & 3;
             rm = modrm & 7;
-#ifdef VBOX /* Fix for obvious bug - T1 needs to be loaded */
-            /** @todo: how to do that right? */
-            //gen_op_mov_TN_reg[ot][1][reg]();
-#endif
             if (mod != 3) {
                 gen_lea_modrm(s, modrm, &reg_addr, &offset_addr);