Changeset 14468 in vbox for trunk

Timestamp:

Nov 21, 2008 3:44:27 PM (16 years ago)

Author:

vboxsync

Message:

linuxevent*-sems.cpp, Makefile.kmk: update the explanation and dropped the INCS.

Location:

trunk/src/VBox/Runtime

Files:

trunk/src/VBox/Runtime/Makefile.kmk

-              r14429
+              r14468
         r3/linux/semevent-linux.cpp \
         r3/linux/semeventmulti-linux.cpp
-# with glibc >= 2.6 we use the libc implementation
-r3/linux/semevent-linux.cpp_INCS = .
-r3/linux/semeventmulti-linux.cpp_INCS = .
 ifdef RT_NEW_LINUX_MUTEX_CODE
  RuntimeR3_SOURCES.linux.amd64 += \

-              r14429
+              r14468
 #if __GLIBC_PREREQ(2,6)
+/* glibc 2.6 fixed a serious bug in the mutex implementation
+ * The external refernce to epoll_pwait is a hack which prevents
+ * that we link against glibc < 2.6 */
+/*
+ * glibc 2.6 fixed a serious bug in the mutex implementation. We wrote this
+ * linux specific event semaphores code in order to work around the bug. As it
+ * turns out, this code seems to have an unresolved issue (#2599), so we'll
+ * fall back on the pthread based implementation if glibc is known to contain
+ * the bug fix.
+ *
+ * The external refernce to epoll_pwait is a hack which prevents that we link
+ * against glibc < 2.6.
+ */
+#include "../posix/semevent-posix.cpp"
 asm volatile (".global epoll_pwait");
-#include "r3/posix/semevent-posix.cpp"
 #else /* glibc < 2.6 */

-              r14429
+              r14468
 #if __GLIBC_PREREQ(2,6)
+/* glibc 2.6 fixed a serious bug in the mutex implementation.
+ * The external refernce to epoll_pwait is a hack which prevents
+ * that we link against glibc < 2.6 */
+/*
+ * glibc 2.6 fixed a serious bug in the mutex implementation. We wrote this
+ * linux specific event semaphores code in order to work around the bug. As it
+ * turns out, this code seems to have an unresolved issue (#2599), so we'll
+ * fall back on the pthread based implementation if glibc is known to contain
+ * the bug fix.
+ *
+ * The external refernce to epoll_pwait is a hack which prevents that we link
+ * against glibc < 2.6.
+ */
+#include "../posix/semeventmulti-posix.cpp"
 asm volatile (".global epoll_pwait");
-#include "r3/posix/semeventmulti-posix.cpp"
 #else /* glibc < 2.6 */

Note: See TracChangeset for help on using the changeset viewer.