Changeset 14543 in vbox

Timestamp:

Nov 24, 2008 7:36:37 PM (16 years ago)

Author:

vboxsync

Message:

#1865/VT-x: Attacking the heap allocation, introducing VMMIsHwVirtExtForced which will only return true on darwin (for now at least).

Location:

trunk

Files:

• include/VBox/vm.h (modified) (1 diff)
• include/VBox/vm.mac (modified) (1 diff)
• include/VBox/vmm.h (modified) (1 diff)
• src/VBox/Main/ConsoleImpl2.cpp (modified) (1 diff)
• src/VBox/VMM/MMHyper.cpp (modified) (1 diff)
• src/VBox/VMM/VM.cpp (modified) (2 diffs)

trunk/include/VBox/vm.h

@@ -537 +537 @@
      * This is placed here for performance reasons. */
     bool                fCSAMEnabled;
-
     /** Hardware VM support is available and enabled.
      * This is placed here for performance reasons. */
     bool                fHWACCMEnabled;
-
+    /** Hardware VM support is required and non-optional.
+     * This is initialized together with the rest of the VM structure. */
+    bool                fHwVirtExtForced;
     /** PARAV enabled flag. */
     bool                fPARAVEnabled;

trunk/include/VBox/vm.mac

@@ -72 +72 @@
     .fPATMEnabled       resb 1
     .fCSAMEnabled       resb 1
-    .fHWACCMEnabled     resb 3
+    .fHWACCMEnabled     resb 1
+    .fHwVirtExtForced   resb 1
+    .fPARAVEnabled      resb 1
 
     alignb 8

trunk/include/VBox/vmm.h

@@ -118 +118 @@
 VMMDECL(uint32_t)   VMMGetSvnRev(void);
 
+/** @def VMMIsHwVirtExtForced
+ * Checks if forced to use the hardware assisted virtualization extensions.
+ *
+ * This is intended for making setup decisions where we can save resources when
+ * using hardware assisted virtualization.
+ *
+ * @returns true / false.
+ * @param   pVM     Pointer to the shared VM structure. */
+#define VMMIsHwVirtExtForced(pVM)   ((pVM)->fHwVirtExtForced)
+
 
 #ifdef IN_RING3

trunk/src/VBox/Main/ConsoleImpl2.cpp

@@ -205 +205 @@
     else
         fHWVirtExEnabled = (hwVirtExEnabled == TSBool_True);
-#ifndef RT_OS_DARWIN /** @todo Implement HWVirtExt on darwin. See #1865. */
+#ifdef RT_OS_DARWIN
+    rc = CFGMR3InsertInteger(pRoot, "HwVirtExtForced",      fHWVirtExEnabled);      RC_CHECK();
+#else
+    rc = CFGMR3InsertInteger(pRoot, "HwVirtExtForced",      0);                     RC_CHECK();
+#endif
     if (fHWVirtExEnabled)
     {
         PCFGMNODE pHWVirtExt;
         rc = CFGMR3InsertNode(pRoot, "HWVirtExt", &pHWVirtExt);                     RC_CHECK();
-        rc = CFGMR3InsertInteger(pHWVirtExt, "Enabled", 1);                         RC_CHECK();
-    }
-#endif
+        rc = CFGMR3InsertInteger(pHWVirtExt, "Enabled",     1);                     RC_CHECK();
+    }
 
     /* Nested paging (VT-x/AMD-V) */

trunk/src/VBox/VMM/MMHyper.cpp

@@ -781 +781 @@
      * Allocate the hypervisor heap.
      */
-    const uint32_t cbAligned = RT_ALIGN_32(cb, PAGE_SIZE);
+    const uint32_t  cbAligned = RT_ALIGN_32(cb, PAGE_SIZE);
     AssertReturn(cbAligned >= cb, VERR_INVALID_PARAMETER);
-    void *pv;
-    int rc = SUPPageAlloc(cbAligned >> PAGE_SHIFT, &pv); /** @todo #1865: heap allocation must be changed for osx (only). */
+    int             rc;
+    void           *pv;
+    RTR0PTR         pvR0;
+#if 1
+    rc = SUPPageAlloc(cbAligned >> PAGE_SHIFT, &pv); /** @todo #1865: heap allocation must be changed for osx (only). */
+    pvR0 = (uintptr_t)pv;
+#else /**@todo resume here. */
+    if (VMMIsHwVirtExtForced(pVM))
+        rc = SUPPageAllocKernel((cbAligned >> PAGE_SHIFT, &pv, &pvR0, paPages);
+    else
+    {
+        rc = SUPPageAllocLocked((cbAligned >> PAGE_SHIFT, &pv, paPages);
+        pvR0 = (uintptr_t)pv;
+    }
+#endif
     if (RT_SUCCESS(rc))
     {

trunk/src/VBox/VMM/VM.cpp

@@ -526 +526 @@
         if (RT_SUCCESS(rc))
         {
+            rc = CFGMR3QueryBoolDef(CFGMR3GetRoot(pVM), "fHwVirtExtForced", &pVM->fHwVirtExtForced, false);
+            if (RT_SUCCESS(rc) && pVM->fHwVirtExtForced)
+                pVM->fHWACCMEnabled = true;
+
             /*
              * If executing in fake suplib mode disable RR3 and RR0 in the config.
@@ -541 +545 @@
              * Make sure the CPU count in the config data matches.
              */
-            uint32_t cCPUsCfg;
-            rc = CFGMR3QueryU32Def(CFGMR3GetRoot(pVM), "NumCPUs", &cCPUsCfg, 1);
-            AssertLogRelMsgRC(rc, ("Configuration error: Querying \"NumCPUs\" as integer failed, rc=%Rrc\n", rc));
-            if (RT_SUCCESS(rc) && cCPUsCfg != cCPUs)
+            if (RT_SUCCESS(rc))
             {
-                AssertLogRelMsgFailed(("Configuration error: \"NumCPUs\"=%RU32 and VMR3CreateVM::cCPUs=%RU32 does not match!\n",
-                                       cCPUsCfg, cCPUs));
-                rc = VERR_INVALID_PARAMETER;
+                uint32_t cCPUsCfg;
+                rc = CFGMR3QueryU32Def(CFGMR3GetRoot(pVM), "NumCPUs", &cCPUsCfg, 1);
+                AssertLogRelMsgRC(rc, ("Configuration error: Querying \"NumCPUs\" as integer failed, rc=%Rrc\n", rc));
+                if (RT_SUCCESS(rc) && cCPUsCfg != cCPUs)
+                {
+                    AssertLogRelMsgFailed(("Configuration error: \"NumCPUs\"=%RU32 and VMR3CreateVM::cCPUs=%RU32 does not match!\n",
+                                           cCPUsCfg, cCPUs));
+                    rc = VERR_INVALID_PARAMETER;
+                }
             }
             if (RT_SUCCESS(rc))