Changeset 14770 in vbox for trunk/src

Timestamp:

Nov 28, 2008 11:04:41 AM (16 years ago)

Author:

vboxsync

Message:

#3285: Improve error handling API to include unique error numbers
Document IConsole::powerUp

Location:

trunk/src/VBox/Main

Files:

• ConsoleImpl.cpp (modified) (5 diffs)
• idl/VirtualBox.xidl (modified) (2 diffs)

trunk/src/VBox/Main/ConsoleImpl.cpp

@@ -4274 +4274 @@
 
     if (mMachineState >= MachineState_Running)
-        return setError(E_FAIL, tr ("Virtual machine is already running "
-                                    "(machine state: %d)"),
-                        mMachineState);
+        return setError(VBOX_E_INVALID_VM_STATE,
+            tr ("Virtual machine is already running "
+            "(machine state: %d)"), mMachineState);
 
     HRESULT rc = S_OK;
@@ -4302 +4302 @@
                 if (!hostif)
                 {
-                    return setError (E_FAIL,
+                    return setError (VBOX_E_HOST_ERROR,
                         tr ("VM cannot start because host interface networking "
                             "requires a host interface name to be set"));
@@ -4315 +4315 @@
                 if (!SUCCEEDED(coll->FindByName(hostif, hostInterface.asOutParam())))
                 {
-                    return setError (E_FAIL,
+                    return setError (VBOX_E_HOST_ERROR,
                         tr ("VM cannot start because the host interface '%ls' "
                             "does not exist"),
@@ -4363 +4363 @@
         int vrc = SSMR3ValidateFile (Utf8Str (savedStateFile));
         if (VBOX_FAILURE (vrc))
-            return setError (E_FAIL,
+            return setError (VBOX_E_FILE_ERROR,
                 tr ("VM cannot start because the saved state file '%ls' is invalid (%Rrc). "
                     "Discard the saved state prior to starting the VM"),
@@ -7456 +7456 @@
     NULL
 };
-
+/* vi: set tabstop=4 shiftwidth=4 expandtab: */

trunk/src/VBox/Main/idl/VirtualBox.xidl

@@ -310 +310 @@
   </result>
 
+  <result name="VBOX_E_HOST_ERROR" value="0x80BB0008">
+    <desc>
+       Host operating system related error.
+    </desc>
+  </result>
+
   <!--
     Note that src/VBox/Runtime/common/err/errmsgvboxcom.xsl will ignore
@@ -4562 +4568 @@
 
         <see>#saveState</see>
+        <result name="VBOX_E_INVALID_VM_STATE">
+          Virtual machine already running.
+        </result>
+        <result name="VBOX_E_HOST_ERROR">
+          Host interface does not exist or name not set.
+        </result>
+        <result name="VBOX_E_FILE_ERROR">
+          Invalid saved state file.
+        </result>
       </desc>
       <param name="progress" type="IProgress" dir="return">