Changeset 14931 in vbox for trunk/src

Timestamp:

Dec 3, 2008 12:33:47 AM (16 years ago)

Author:

vboxsync

Message:

Main: HardDisk2: Obey VD_CAP_UUID.

Location:

trunk/src/VBox/Main

Files:

• HardDisk2Impl.cpp (modified) (18 diffs)
• MediumImpl.cpp (modified) (1 diff)
• VirtualBoxImpl.cpp (modified) (1 diff)
• idl/VirtualBox.xidl (modified) (2 diffs)

trunk/src/VBox/Main/HardDisk2Impl.cpp

@@ -1874 +1874 @@
            HardDiskFormatCapabilities_CreateFixed)))
         return setError (VBOX_E_NOT_SUPPORTED,
-            tr ("Hard disk format '%ls' does not support storage deletion "),
+            tr ("Hard disk format '%ls' does not support storage deletion"),
             mm.format.raw());
 
@@ -2410 +2410 @@
                   E_FAIL);
 
-    /* are we dealing with a hard disk just opened from the existing path? */
-    bool isNew = mm.format.isNull();
-
-    if (isNew ||
+    /* are we dealing with a new hard disk constructed using the existing
+     * location? */
+    bool isImport = mm.format.isNull();
+
+    if (isImport ||
         (mm.formatObj->capabilities() & HardDiskFormatCapabilities_File))
     {
@@ -2466 +2467 @@
                 location.raw(), vrc);
 
-        /* detect the backend from the storage unit if new */
-        if (isNew)
+        /* detect the backend from the storage unit if importing */
+        if (isImport)
         {
             char *backendName = NULL;
@@ -2510 +2511 @@
             m.locationFull = locationFull;
 
-            /* assign a new UUID if we generated it */
-            if (!id.isEmpty())
+            if (m.state == MediaState_NotCreated)
+            {
+                /* assign a new UUID (this UUID will be used when calling
+                 * VDCreateBase/VDCreateDiff as a wanted UUID). Note that we
+                 * also do that if we didn't generate it to make sure it is
+                 * either generated by us or reset to null */
                 unconst (m.id) = id;
+            }
         }
         else
@@ -2657 +2663 @@
         Utf8Str location (m.locationFull);
 
-        /* are we dealing with a hard disk opened from the existing path? */
-        bool isNew = m.id.isEmpty();
+        /* are we dealing with a new hard disk constructed using the existing
+         * location? */
+        bool isImport = m.id.isEmpty();
 
         PVBOXHDD hdd;
@@ -2673 +2680 @@
              * time in VirtualBox (such as VMDK for which VDOpen() needs to
              * generate an UUID if it is missing) */
-            if (!isNew)
+            if (!isImport)
                 flags |= VD_OPEN_FLAGS_READONLY;
 
@@ -2686 +2693 @@
             }
 
-            /* check the UUID */
-            RTUUID uuid;
-            vrc = VDGetUuid (hdd, 0, &uuid);
-            ComAssertRCThrow (vrc, E_FAIL);
-
-            if (isNew)
+            if (mm.formatObj->capabilities() & HardDiskFormatCapabilities_Uuid)
             {
-                unconst (m.id) = uuid;
+                /* check the UUID */
+                RTUUID uuid;
+                vrc = VDGetUuid (hdd, 0, &uuid);
+                ComAssertRCThrow (vrc, E_FAIL);
+
+                if (isImport)
+                {
+                    unconst (m.id) = uuid;
+                }
+                else
+                {
+                    Assert (!m.id.isEmpty());
+
+                    if (m.id != uuid)
+                    {
+                        lastAccessError = Utf8StrFmt (
+                            tr ("UUID {%RTuuid} of the hard disk '%ls' does "
+                                "not match the value {%RTuuid} stored in the "
+                                "media registry ('%ls')"),
+                            &uuid, m.locationFull.raw(), m.id.raw(),
+                            mVirtualBox->settingsFileName().raw());
+                        throw S_OK;
+                    }
+                }
             }
             else
             {
-                if (m.id != uuid)
-                {
-                    lastAccessError = Utf8StrFmt (
-                        tr ("UUID {%RTuuid} of the hard disk '%ls' "
-                            "does not match the value {%RTuuid} stored in the "
-                            "media registry ('%ls')"),
-                        &uuid, m.locationFull.raw(), m.id.raw(),
-                        mVirtualBox->settingsFileName().raw());
-                    throw S_OK;
-                }
+                /* the backend does not support storing UUIDs within the
+                 * underlying storage so use what we store in XML */
+
+                /* generate an UUID for an imported UUID-less hard disk */
+                if (isImport)
+                    unconst (m.id).create();
             }
 
@@ -2716 +2737 @@
             if (type == VD_IMAGE_TYPE_DIFF)
             {
-                vrc = VDGetParentUuid (hdd, 0, &uuid);
+                RTUUID parentId;
+                vrc = VDGetParentUuid (hdd, 0, &parentId);
                 ComAssertRCThrow (vrc, E_FAIL);
 
-                if (isNew)
+                if (isImport)
                 {
                     /* the parent must be known to us. Note that we freely
@@ -2728 +2750 @@
                      * fail if this method reporst MediaState_Inaccessible) */
 
-                    Guid id = uuid;
+                    Guid id = parentId;
                     ComObjPtr <HardDisk2> parent;
                     rc = mVirtualBox->findHardDisk2 (&id, NULL,
@@ -2739 +2761 @@
                                 "hard disk '%ls' is not found in the media "
                                 "registry ('%ls')"),
-                            &uuid, m.locationFull.raw(),
+                            &parentId, m.locationFull.raw(),
                             mVirtualBox->settingsFileName().raw());
                         throw S_OK;
@@ -2777 +2799 @@
                     AutoReadLock parentLock (mParent);
                     if (mParent->state() != MediaState_Inaccessible &&
-                        mParent->id() != uuid)
+                        mParent->id() != parentId)
                     {
                         lastAccessError = Utf8StrFmt (
@@ -2783 +2805 @@
                                 "does not match UUID {%RTuuid} of its parent "
                                 "hard disk stored in the media registry ('%ls')"),
-                            &uuid, m.locationFull.raw(),
+                            &parentId, m.locationFull.raw(),
                             mParent->id().raw(),
                             mVirtualBox->settingsFileName().raw());
@@ -3118 +3140 @@
 
             /* these parameters we need after creation */
-            RTUUID uuid;
             uint64_t size = 0, logicalSize = 0;
+
+            /* the object may request a specific UUID (through a special
+             * form of the setLocation() argumet) */
+            Guid id = that->m.id;
 
             try
@@ -3129 +3154 @@
                 Utf8Str format (that->mm.format);
                 Utf8Str location (that->m.locationFull);
+                ULONG capabilities = that->mm.formatObj->capabilities();
 
                 /* unlock before the potentially lengthy operation */
@@ -3151 +3177 @@
                                         task->d.size * _1M,
                                         VD_IMAGE_FLAGS_NONE,
-                                        NULL, &geo, &geo, NULL,
+                                        NULL, &geo, &geo,
+                                        id.isEmpty() ? NULL : id.raw(),
                                         VD_OPEN_FLAGS_NORMAL,
                                         NULL, that->mm.vdDiskIfaces);
@@ -3163 +3190 @@
                     }
 
-                    vrc = VDGetUuid (hdd, 0, &uuid);
-                    ComAssertRCThrow (vrc, E_FAIL);
+                    if (capabilities & HardDiskFormatCapabilities_Uuid)
+                    {
+                        RTUUID uuid;
+                        vrc = VDGetUuid (hdd, 0, &uuid);
+                        ComAssertRCThrow (vrc, E_FAIL);
+
+                        if (!id.isEmpty())
+                            Assert (id == uuid);
+                        else
+                            id = uuid;
+                    }
+                    else
+                    {
+                        /* we have to generate an UUID ourselves */
+                        id.create();
+                    }
 
                     size = VDGetFileSize (hdd, 0);
@@ -3181 +3222 @@
                 thatLock.enter();
 
-                unconst (that->m.id) = uuid;
+                unconst (that->m.id) = id;
 
                 that->m.size = size;
@@ -3707 +3748 @@
             that->m.state = MediaState_NotCreated;
 
+            /* Reset UUID to prevent Create* from reusing it again */
+            unconst (that->m.id).clear();
+
             break;
         }

trunk/src/VBox/Main/MediumImpl.cpp

@@ -59 +59 @@
     CheckComRCReturnRC (autoCaller.rc());
 
-    /* m.id is constant during life time, no need to lock */
+    AutoReadLock alock (this);
+
     m.id.cloneTo (aId);
 

trunk/src/VBox/Main/VirtualBoxImpl.cpp

@@ -490 +490 @@
 # error "Port me!"
 #endif
-    /* Unload plugin backends. */
+
+    /* Unload hard disk plugin backends. */
     VDShutdown();
 

trunk/src/VBox/Main/idl/VirtualBox.xidl

@@ -6647 +6647 @@
         UUID of the medium. For a newly created medium, this value is a randomly
         generated UUID.
+
+        <note>
+          For media in one of MediaState::NotCreated, MediaState::Creating or
+          MediaState::Deleting states, the value of this property is undefined
+          and will most likely be an empty UUID.
+        </note>
       </desc>
     </attribute>
@@ -7601 +7607 @@
           <link to="IHardDiskFormat::capabilities"/>.
         </result>
+
+        <note>
+          If the deletion operation fails, it is not guaranteed that the storage
+          unit still exists. You may check the <link to="IMedium::state"/> value
+          to answer this question.
+        </note>
       </desc>
       <param name="progress" type="IProgress" dir="return">