Changeset 14972 in vbox for trunk/src/VBox/Main/include

Timestamp:

Dec 4, 2008 12:10:37 PM (16 years ago)

Author:

vboxsync

Message:

#3285: Improve error handling API to include unique error numbers

The mega commit that implements Main-wide usage of new CheckCom*
macros, mostly CheckComArgNotNull, CheckComArgStrNotEmptyOrNull,
CheckComArgOutSafeArrayPointerValid, CheckComArgExpr.
Note that some methods incorrectly returned E_INVALIDARG where they
should have returned E_POINTER and vice versa. If any higher level
function tests these, they will behave differently now...

Special thanks to: vi macros, making it easy to semi-automatically
find and replace several hundred instances of if (!aName) ...

Location:

trunk/src/VBox/Main/include

Files:

• FramebufferImpl.h (modified) (1 diff)
• VirtualBoxErrorInfoImpl.h (modified) (1 diff)

trunk/src/VBox/Main/include/FramebufferImpl.h

@@ -80 +80 @@
 
 private:
+    // FIXME: declare these here until VBoxSupportsTranslation base
+    //        is available in this class.
+    static const char *tr (const char *a) { return a; }
+    static HRESULT setError (HRESULT rc, const char *a,
+                             const char *b, void *c) { return rc; }
+
     int mWidth;
     int mHeight;

trunk/src/VBox/Main/include/VirtualBoxErrorInfoImpl.h

@@ -81 +81 @@
 
 private:
+    // FIXME: declare these here until VBoxSupportsTranslation base
+    //        is available in this class.
+    static const char *tr (const char *a) { return a; }
+    static HRESULT setError (HRESULT rc, const char *a,
+                             const char *b, void *c) { return rc; }
 
     HRESULT mResultCode;