Changeset 15132 in vbox for trunk/src/VBox/Frontends

Timestamp:

Dec 8, 2008 8:50:07 PM (16 years ago)

Author:

vboxsync

Message:

FE/Qt: Disable too optimistic assertion in VBoxGlobal::details (CHardDisk2). Should fix GUI crashes during high hard disk management activitiy (creating/deleting) caused by third parties (discarding snapshots and so on).

Location:

trunk/src/VBox/Frontends

Files:

• VirtualBox/src/VBoxGlobal.cpp (modified) (2 diffs)
• VirtualBox4/src/VBoxGlobal.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/VBoxGlobal.cpp

@@ -1816 +1816 @@
         startEnumeratingMedia();
         if (!findMedium (cmedium, medium))
-            AssertFailedReturn (QString::null);
+        {
+            /// @todo Still not found. Means that we are trying to get details
+            /// of a hard disk that was deleted by a third party before we got a
+            /// chance to complete the task. Returning null in this case should
+            /// be OK, For more information, see *** in VBoxMedium::etails().
+            return QString::null;
+        }
     }
 
@@ -1972 +1978 @@
 
             /// @todo for the explaination of the below isOk() checks, see ***
-            /// in #details (const CHardDisk &, bool).
+            /// in VBoxMedium::details().
             if (hda.isOk())
             {

trunk/src/VBox/Frontends/VirtualBox4/src/VBoxGlobal.cpp

@@ -1952 +1952 @@
         startEnumeratingMedia();
         if (!findMedium (cmedium, medium))
-            AssertFailedReturn (QString::null);
+        {
+            /// @todo Still not found. Means that we are trying to get details
+            /// of a hard disk that was deleted by a third party before we got a
+            /// chance to complete the task. Returning null in this case should
+            /// be OK, For more information, see *** in VBoxMedium::etails().
+            return QString::null;
+        }
     }
 
@@ -2162 +2168 @@
 
             /// @todo for the explaination of the below isOk() checks, see ***
-            /// in #details (const CHardDisk &, bool).
+            /// in VBoxMedium::details().
             if (hda.isOk())
             {