Changeset 1532 in vbox for trunk/src/VBox

Timestamp:

Mar 16, 2007 2:54:40 PM (18 years ago)

Author:

vboxsync

Message:

Handle EFBIG on Linux correctly (and try to detect the same situation on
Windows). Provide separate runtime error message, because disk full
doesn't describe the problem (file size limit exceeded). Happens mostly
if people store VDIs on FAT32 partitions.

Location:

trunk/src/VBox

Files:

• Devices/Storage/DevATA.cpp (modified) (3 diffs)
• Runtime/RTErrConvertFromErrno.cpp (modified) (1 diff)
• Runtime/r3/win32/fileio-win32.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Storage/DevATA.cpp

@@ -1375 +1375 @@
 
 
+static void ataWarningFileTooBig(PPDMDEVINS pDevIns)
+{
+    int rc;
+    LogRel(("PIIX3 ATA: File too big\n"));
+    rc = VMSetRuntimeError(PDMDevHlpGetVM(pDevIns),
+                           false, "DevATA_FILETOOBIG",
+                           N_("Host system reported that the file size limit has been exceeded. VM execution is suspended. You need to move the file to a filesystem which allows bigger files"));
+    AssertRC(rc);
+}
+
+
 static void ataWarningISCSI(PPDMDEVINS pDevIns)
 {
@@ -1411 +1422 @@
             return true;
         }
+        if (rc == VERR_FILE_TOO_BIG)
+        {
+            ataWarningFileTooBig(ATADEVSTATE_2_DEVINS(s));
+            return true;
+        }
         if (rc == VERR_BROKEN_PIPE || rc == VERR_NET_CONNECTION_REFUSED)
         {
@@ -1451 +1467 @@
         {
             ataWarningDiskFull(ATADEVSTATE_2_DEVINS(s));
+            return true;
+        }
+        if (rc == VERR_FILE_TOO_BIG)
+        {
+            ataWarningFileTooBig(ATADEVSTATE_2_DEVINS(s));
             return true;
         }

trunk/src/VBox/Runtime/RTErrConvertFromErrno.cpp

@@ -130 +130 @@
 #endif
 #ifdef EFBIG
-        //case EFBIG:
+        case EFBIG:             return VERR_FILE_TOO_BIG;
 #endif
 #ifdef ENOSPC

trunk/src/VBox/Runtime/r3/win32/fileio-win32.cpp

@@ -74 +74 @@
     return fRc;
 }
+
+
+/**
+ * This is a helper to check if an attempt is made to grow a file beyond the
+ * limit of the filesystem.
+ *
+ * @returns true for file size limit exceeded.
+ * @param   File        Filehandle.
+ * @param   offSeek     Offset to seek.
+ */
+inline bool IsBeyondLimit(RTFILE File, uint64_t offSeek, unsigned uMethod)
+{
+    bool fIsBeyondLimit = false;
+    /*
+     * Get current file pointer.
+     */
+    uint64_t    offCurrent;
+    if (MySetFilePointer(File, 0, &offCurrent, FILE_CURRENT))
+    {
+        /*
+         * Set new file pointer.
+         */
+        if (!MySetFilePointer(File, offSeek, NULL, uMethod))
+        {
+            /*
+             * Failed to set new file pointer.
+             */
+            fIsBeyondLimit = (GetLastError() == ERROR_SEEK);
+        }
+        else
+        {
+            /*
+             * Restore file pointer.
+             */
+            MySetFilePointer(File, offCurrent, NULL, FILE_BEGIN);
+        }
+    }
+
+    return fIsBeyondLimit;
+}
+
+
 
 
@@ -307 +349 @@
                 ULONG cbWrittenPart = 0;
                 if (!WriteFile((HANDLE)File, (char*)pvBuf + cbWritten, cbToWrite - cbWritten, &cbWrittenPart, NULL))
-                    return RTErrConvertFromWin32(GetLastError());
+                {
+                    int rc = RTErrConvertFromWin32(GetLastError());
+                    if (   rc == VERR_DISK_FULL
+                        && IsBeyondLimit(File, cbToWrite - cbWritten, FILE_CURRENT)
+                       )
+                        rc = VERR_FILE_TOO_BIG;
+                    return rc;
+                }
                 if (cbWrittenPart == 0)
                     return VERR_WRITE_ERROR;
@@ -315 +364 @@
         return VINF_SUCCESS;
     }
-    return RTErrConvertFromWin32(GetLastError());
+    int rc = RTErrConvertFromWin32(GetLastError());
+    if (   rc == VERR_DISK_FULL
+        && IsBeyondLimit(File, cbToWrite - cbWritten, FILE_CURRENT)
+       )
+        rc = VERR_FILE_TOO_BIG;
+    return rc;
 }