Changeset 1533 in vbox

Timestamp:

Mar 16, 2007 3:03:48 PM (18 years ago)

Author:

vboxsync

Message:

Fix logging and error code handling.

Location:

trunk/src/VBox/Devices/Serial

Files:

• DrvChar.cpp (modified) (1 diff)
• DrvNamedPipe.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Serial/DrvChar.cpp

@@ -97 +97 @@
 {
     PDRVCHAR pData = PDMICHAR_2_DRVCHAR(pInterface);
-    int rc;
+    int rc = VINF_SUCCESS;
 
     LogFlow(("%s: pvBuf=%#p cbWrite=%d\n", __FUNCTION__, pvBuf, cbWrite));

trunk/src/VBox/Devices/Serial/DrvNamedPipe.cpp

@@ -264 +264 @@
             {
                 rc = RTErrConvertFromWin32(hrc);
-                LogRel(("NamedPipe%d: ConnectNamedPipe failed rc=%Vrc\n", pData->pDrvIns->iInstance));
+                LogRel(("NamedPipe%d: ConnectNamedPipe failed, rc=%Vrc\n", pData->pDrvIns->iInstancei, rc));
                 break;
             }
@@ -271 +271 @@
 #else /* !__WIN__ */
         if (listen(pData->LocalSocketServer, 0) == -1)
-            LogRel(("NamedPipe%d: listen failed\n", pData->pDrvIns->iInstance));
+        {
+            rc = RTErrConvertFromErrno(errno);
+            LogRel(("NamedPipe%d: listen failed, rc=%Vrc\n", pData->pDrvIns->iInstance, rc));
+            break;
+        }
         int s = accept(pData->LocalSocketServer, NULL, NULL);
         if (s == -1)
-            LogRel(("NamedPipe%d: accept failed\n", pData->pDrvIns->iInstance));
+        {
+            rc = RTErrConvertFromErrno(errno);
+            LogRel(("NamedPipe%d: accept failed, rc=%Vrc\n", pData->pDrvIns->iInstance, rc));
+            break;
+        }
         else
         {