Changeset 15393 in vbox for trunk/src/VBox/Devices/Network

Timestamp:

Dec 12, 2008 7:16:05 PM (16 years ago)

Author:

vboxsync

Message:

slirp:icmp: move debuging in more correct and safier way

Location:

trunk/src/VBox/Devices/Network/slirp

Files:

• bootp.c (modified) (2 diffs)
• debug.c (modified) (1 diff)
• ip_icmp.c (modified) (1 diff)

trunk/src/VBox/Devices/Network/slirp/bootp.c

@@ -153 +153 @@
         LogRel(("NAT: %s %R[IP4]\n",
                 rc ? "DHCP released IP address" : "Ignored DHCP release for IP address",
-                &bp->bp_ciaddr));
+                bp->bp_ciaddr.s_addr));
         /* This message is not to be answered in any way. */
         return;
@@ -245 +245 @@
     if (send_nak)
         LogRel(("NAT: Client requested IP address %R[IP4] -- sending NAK\n",
-                &requested_ip));
+                requested_ip.s_addr));
     else
         LogRel(("NAT: DHCP offered IP address %R[IP4]\n",
-                &daddr.sin_addr));
+                daddr.sin_addr.s_addr));
 
     if (   dhcp_msg_type == DHCPDISCOVER

trunk/src/VBox/Devices/Network/slirp/debug.c

@@ -230 +230 @@
     AssertReturn(strcmp(pszType, "IP4") == 0, 0);
 
-    ip = ntohl(*(uint32_t*)pvValue);
+    ip = ntohl((uint32_t)(uintptr_t)pvValue);
     return RTStrFormat(pfnOutput, pvArgOutput, NULL, 0, IP4_ADDR_PRINTF_FORMAT,
            IP4_ADDR_PRINTF_DECOMP(ip));

trunk/src/VBox/Devices/Network/slirp/ip_icmp.c

@@ -219 +219 @@
             {
                 /* Should be reaplaced by hash here */
-                LogRel(("trying:%R[natsock] against %R[IP4]:%d lport=%d hlport=%d\n", so, &faddr, fport, lport, so->so_hlport));
+                LogRel(("trying:%R[natsock] against %R[IP4]:%d lport=%d hlport=%d\n", so, faddr.s_addr, fport, lport, so->so_hlport));
                 if (   so->so_faddr.s_addr == faddr.s_addr
                     && so->so_fport == fport