Changeset 15436 in vbox for trunk/src/VBox/VMM/VMMR0/PGMR0DynMap.cpp

Timestamp:

Dec 13, 2008 11:59:30 AM (16 years ago)

Author:

vboxsync

Message:

PGMR0DynMap: Corrected PGMR0DYNMAP_PAGES_PER_CPU_MIN (>= max set size). Added set size stats.

File:

• trunk/src/VBox/VMM/VMMR0/PGMR0DynMap.cpp (modified) (5 diffs)

trunk/src/VBox/VMM/VMMR0/PGMR0DynMap.cpp

@@ -52 +52 @@
 /** The minimum number of pages we reserve per CPU.
  * This must be equal or larger than the autoset size.  */
-#define PGMR0DYNMAP_PAGES_PER_CPU_MIN       32
+#define PGMR0DYNMAP_PAGES_PER_CPU_MIN       64
 /** The number of guard pages.
  * @remarks Never do tuning of the hashing or whatnot with a strict build!  */
@@ -1566 +1566 @@
     pSet->iCpu = -1;
 
+    STAM_COUNTER_INC(&pVCpu->pVMR0->pgm.s.aStatR0DynMapSetSize[(cEntries * 10 / RT_ELEMENTS(pSet->aEntries)) % 11]);
     AssertMsg(cEntries < PGMMAPSET_MAX_FILL, ("%u\n", cEntries));
     if (cEntries > RT_ELEMENTS(pSet->aEntries) * 50 / 100)
@@ -1589 +1590 @@
     uint32_t cEntries = pSet->cEntries;
     AssertReturnVoid(cEntries != PGMMAPSET_CLOSED);
+    STAM_COUNTER_INC(&pVCpu->pVMR0->pgm.s.aStatR0DynMapSetSize[(cEntries * 10 / RT_ELEMENTS(pSet->aEntries)) % 11]);
     if (cEntries >= RT_ELEMENTS(pSet->aEntries) * 45 / 100)
     {
@@ -1733 +1735 @@
 {
     PPGMMAPSET      pSet = &pVCpu->pgm.s.AutoSet;
-    AssertReturnVoid(pSet->cEntries != PGMMAPSET_CLOSED);
+    uint32_t        cEntries = pSet->cEntries;
+    AssertReturnVoid(cEntries != PGMMAPSET_CLOSED);
     AssertReturnVoid(pSet->iSubset <= iPrevSubset || iPrevSubset == UINT32_MAX);
 Assert(iPrevSubset == UINT32_MAX);
-    if (    pSet->cEntries >= RT_ELEMENTS(pSet->aEntries) * 40 / 100
-        &&  pSet->cEntries != pSet->iSubset)
-    {
-        AssertMsg(pSet->cEntries < PGMMAPSET_MAX_FILL, ("%u\n", pSet->cEntries));
-        STAM_COUNTER_INC(&pVCpu->pVMR0->pgm.s.StatR0DynMapPopFlushes);
+    STAM_COUNTER_INC(&pVCpu->pVMR0->pgm.s.aStatR0DynMapSetSize[(cEntries * 10 / RT_ELEMENTS(pSet->aEntries)) % 11]);
+    if (    cEntries >= RT_ELEMENTS(pSet->aEntries) * 40 / 100
+        &&  cEntries != pSet->iSubset)
+    {
+        AssertMsg(cEntries < PGMMAPSET_MAX_FILL, ("%u\n", cEntries));
         pgmDynMapFlushSubset(pSet);
     }
@@ -1888 +1891 @@
             {
                 STAM_COUNTER_INC(&pVM->pgm.s.StatR0DynMapSetSearchFlushes);
+                STAM_COUNTER_INC(&pVM->pgm.s.aStatR0DynMapSetSize[(pSet->cEntries * 10 / RT_ELEMENTS(pSet->aEntries)) % 11]);
                 AssertMsg(pSet->cEntries < PGMMAPSET_MAX_FILL, ("%u\n", pSet->cEntries));
                 pgmDynMapFlushSubset(pSet);