Changeset 15707 in vbox for trunk/src/VBox/HostServices

Timestamp:

Dec 19, 2008 6:16:40 PM (16 years ago)

Author:

vboxsync

Message:

crOpenGL: make host buffer dynamic in size, fix for 3443

Location:

trunk/src/VBox/HostServices/SharedOpenGL

Files:

• crserver/crservice.cpp (modified) (2 diffs)
• crserverlib/server_main.c (modified) (1 diff)

trunk/src/VBox/HostServices/SharedOpenGL/crserver/crservice.cpp

@@ -297 +297 @@
                 /* Update parameters.*/
                 paParms[0].u.pointer.size = cbBuffer; //@todo guest doesn't see this change somehow?
-                paParms[1].u.uint32 = cbBuffer;
-            }
+            }
+
+            /* Return the required buffer size always */
+            paParms[1].u.uint32 = cbBuffer;
 
             break;
@@ -337 +339 @@
                     /* Update parameters.*/
                     paParms[1].u.pointer.size = cbWriteback;
-                    paParms[2].u.uint32 = cbWriteback;
                 }
+                /* Return the required buffer size always */
+                paParms[2].u.uint32 = cbWriteback;
             }
             break;

trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/server_main.c

@@ -460 +460 @@
         crWarning("crServer: [%lx] ClientRead u32ClientID=%d FAIL, host buffer too small %d of %d",
                   crThreadID(), u32ClientID, *pcbBuffer, pClient->conn->cbHostBuffer);
-        return VERR_INVALID_PARAMETER;
+
+        /* Return the size of needed buffer */
+        *pcbBuffer = pClient->conn->cbHostBuffer;
+
+        return VERR_BUFFER_OVERFLOW;
     }