Changeset 1581 in vbox

Timestamp:

Mar 20, 2007 8:21:21 PM (18 years ago)

Author:

vboxsync

Message:

r=bird: Too verbose comments that just repeated the code (fixed).

File:

• trunk/src/VBox/Runtime/r3/win32/fileio-win32.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/r3/win32/fileio-win32.cpp

@@ -77 +77 @@
 
 /**
- * This is a helper to check if an attempt is made to grow a file beyond the
+ * This is a helper to check if an attempt was made to grow a file beyond the
  * limit of the filesystem.
  *
@@ -84 +84 @@
  * @param   offSeek     Offset to seek.
  */
-inline bool IsBeyondLimit(RTFILE File, uint64_t offSeek, unsigned uMethod)
+DECLINLINE(bool) IsBeyondLimit(RTFILE File, uint64_t offSeek, unsigned uMethod)
 {
     bool fIsBeyondLimit = false;
-    /*
-     * Get current file pointer.
-     */
-    uint64_t    offCurrent;
+
+    /*
+     * Get the current file position and try set the new one.
+     * If it fails with a seek error it's because we hit the file system limit.
+     */
+    uint64_t offCurrent;
     if (MySetFilePointer(File, 0, &offCurrent, FILE_CURRENT))
     {
-        /*
-         * Set new file pointer.
-         */
         if (!MySetFilePointer(File, offSeek, NULL, uMethod))
-        {
-            /*
-             * Failed to set new file pointer.
-             */
-            fIsBeyondLimit = (GetLastError() == ERROR_SEEK);
-        }
-        else
-        {
-            /*
-             * Restore file pointer.
-             */
+            fIsBeyondLimit = GetLastError() == ERROR_SEEK;
+        else /* Restore file pointer on success. */
             MySetFilePointer(File, offCurrent, NULL, FILE_BEGIN);
-        }
     }
 
     return fIsBeyondLimit;
 }
-
-