Changeset 15974 in vbox

Timestamp:

Jan 15, 2009 5:22:18 PM (16 years ago)

Author:

vboxsync

Message:

XPCOM: fix a race condition in ipcDConnectService::Init.

File:

• trunk/src/libs/xpcom18a4/ipc/ipcd/extensions/dconnect/src/ipcDConnectService.cpp (modified) (1 diff)

trunk/src/libs/xpcom18a4/ipc/ipcd/extensions/dconnect/src/ipcDConnectService.cpp

@@ -2902 +2902 @@
     return NS_ERROR_OUT_OF_MEMORY;
 
+#ifdef VBOX
+  /* The DConnectWorker::Run method checks the ipcDConnectService::mDisconnected.
+   * So mDisconnect must be set here to avoid an immediate exit of the worker thread.
+   */
+  mDisconnected = PR_FALSE;
+#endif /* VBOX */
+
   // create a single worker thread
   rv = CreateWorker();
   if (NS_FAILED(rv))
-      return rv;
+#ifndef VBOX
+    return rv;
+#else /* VBOX */
+  {
+    mDisconnected = PR_TRUE;
+    return rv;
+  }
+#endif /* VBOX */
 
 #endif