Changeset 16021 in vbox for trunk/src/VBox/VMM

Timestamp:

Jan 19, 2009 12:34:50 AM (16 years ago)

Author:

vboxsync

Message:

PDM: Add new flags which will make the device notified first if the VM is suspended if set

File:

• trunk/src/VBox/VMM/PDM.cpp (modified) (4 diffs)

trunk/src/VBox/VMM/PDM.cpp

@@ -976 +976 @@
     for (PPDMDEVINS pDevIns = pVM->pdm.s.pDevInstances; pDevIns; pDevIns = pDevIns->Internal.s.pNextR3)
     {
+        /*
+         * Some devices need to be notified first that the VM is suspended to ensure that that there are no pending
+         * requests from the guest which are still processed. Calling the drivers before these requests are finished
+         * might lead to errors otherwise. One example is the SATA controller which might still have I/O requests
+         * pending. But DrvVD sets the files into readonly mode and every request will fail then.
+         */
+        if (pDevIns->pDevReg->pfnSuspend && (pDevIns->pDevReg->fFlags & PDM_DEVREG_FLAGS_FIRST_SUSPEND_NOTIFICATION))
+        {
+            LogFlow(("PDMR3Suspend: Notifying - device '%s'/%d\n",
+                     pDevIns->pDevReg->szDeviceName, pDevIns->iInstance));
+            pDevIns->pDevReg->pfnSuspend(pDevIns);
+        }
+
         for (PPDMLUN pLun = pDevIns->Internal.s.pLunsR3; pLun; pLun = pLun->pNext)
             for (PPDMDRVINS pDrvIns = pLun->pTop; pDrvIns; pDrvIns = pDrvIns->Internal.s.pDown)
@@ -985 +998 @@
                 }
 
-        if (pDevIns->pDevReg->pfnSuspend)
+        /* Don't call the suspend notification again if it was already called. */
+        if (pDevIns->pDevReg->pfnSuspend && !(pDevIns->pDevReg->fFlags & PDM_DEVREG_FLAGS_FIRST_SUSPEND_NOTIFICATION))
         {
             LogFlow(("PDMR3Suspend: Notifying - device '%s'/%d\n",
@@ -1102 +1116 @@
     for (PPDMDEVINS pDevIns = pVM->pdm.s.pDevInstances; pDevIns; pDevIns = pDevIns->Internal.s.pNextR3)
     {
+
+        if (pDevIns->pDevReg->pfnPowerOff && (pDevIns->pDevReg->fFlags & PDM_DEVREG_FLAGS_FIRST_POWEROFF_NOTIFICATION))
+        {
+            LogFlow(("PDMR3PowerOff: Notifying - device '%s'/%d\n",
+                     pDevIns->pDevReg->szDeviceName, pDevIns->iInstance));
+            pDevIns->pDevReg->pfnPowerOff(pDevIns);
+        }
+
         for (PPDMLUN pLun = pDevIns->Internal.s.pLunsR3; pLun; pLun = pLun->pNext)
             for (PPDMDRVINS pDrvIns = pLun->pTop; pDrvIns; pDrvIns = pDrvIns->Internal.s.pDown)
@@ -1111 +1133 @@
                 }
 
-        if (pDevIns->pDevReg->pfnPowerOff)
+        if (pDevIns->pDevReg->pfnPowerOff && !(pDevIns->pDevReg->fFlags & PDM_DEVREG_FLAGS_FIRST_POWEROFF_NOTIFICATION))
         {
             LogFlow(("PDMR3PowerOff: Notifying - device '%s'/%d\n",