Changeset 1627 in vbox

Timestamp:

Mar 22, 2007 4:24:20 PM (18 years ago)

Author:

vboxsync

Message:

prevent RX/TX during suspend

File:

• trunk/src/VBox/Devices/Network/DevPCNet.cpp (modified) (7 diffs)

trunk/src/VBox/Devices/Network/DevPCNet.cpp

@@ -214 +214 @@
     /** If set the link is temporarily down because of a saved state load. */
     bool                                fLinkTempDown;
+    /** This flag is set on SavePrep to prevent altering of memory after pgmR3Save() was called */
+    bool                                fSaving;
 
     /** Number of times we've reported the link down. */
@@ -1990 +1992 @@
     pcnetXmitFlushFrames(pData);
 #else
-
-#if 1
+# if 1
     PPDMQUEUEITEMCORE pItem = PDMQueueAlloc(CTXSUFF(pData->pXmitQueue));
     if (RT_UNLIKELY(pItem))
         PDMQueueInsert(CTXSUFF(pData->pXmitQueue), pItem);
-#else
+# else
     if (ASMAtomicIncU32(&pData->cPendingSends) < 16)
     {
@@ -2004 +2005 @@
     else
         PDMQueueFlush(CTXSUFF(pData->pXmitQueue));
-#endif
+# endif
 #endif
 }
@@ -2270 +2271 @@
         AssertReleaseRC(rc);
 
-        rc = pcnetAsyncTransmit(pData);
+        if (!pData->fSaving)
+            rc = pcnetAsyncTransmit(pData);
+
         PDMCritSectLeave(&pData->CritSect);
     }
@@ -3658 +3661 @@
 
 /**
+ * Prepares for state saving.
+ * We must stop the RX process to prevent altering of the main memory after saving.
+ *
+ * @returns VBox status code.
+ * @param   pDevIns     The device instance.
+ * @param   pSSMHandle  The handle to save the state to.
+ */
+static DECLCALLBACK(int) pcnetSavePrep(PPDMDEVINS pDevIns, PSSMHANDLE pSSMHandle)
+{
+    PCNetState *pData = PDMINS2DATA(pDevIns, PCNetState *);
+
+    PDMCritSectEnter(&pData->CritSect, VERR_PERMISSION_DENIED);
+
+    pData->fSaving = true;
+    /* From now on drop all received packets to prevent altering of main memory after
+     * pgmR3Save() was called but before the RX thread is terminated */
+
+    PDMCritSectLeave(&pData->CritSect);
+    return VINF_SUCCESS;
+}
+
+
+/**
  * Saves a state of the PC-Net II device.
  *
@@ -3827 +3853 @@
     AssertReleaseRC(rc);
 
-    if (cb > 70) /* unqualified guess */
-        pData->Led.Asserted.s.fReading = pData->Led.Actual.s.fReading = 1;
-    pcnetReceiveNoSync(pData, (const uint8_t*)pvBuf, cb);
-    pData->Led.Actual.s.fReading = 0;
+    if (!pData->fSaving)
+    {
+        if (cb > 70) /* unqualified guess */
+            pData->Led.Asserted.s.fReading = pData->Led.Actual.s.fReading = 1;
+        pcnetReceiveNoSync(pData, (const uint8_t*)pvBuf, cb);
+        pData->Led.Actual.s.fReading = 0;
+    }
+    /* otherwise junk the data to Nirwana. */
 
     PDMCritSectLeave(&pData->CritSect);
@@ -4178 +4208 @@
     rc = PDMDevHlpSSMRegister(pDevIns, pDevIns->pDevReg->szDeviceName, iInstance,
                               PCNET_SAVEDSTATE_VERSION, sizeof(*pData),
-                              NULL, pcnetSaveExec, NULL,
+                              pcnetSavePrep, pcnetSaveExec, NULL,
                               NULL, pcnetLoadExec, NULL);
     if (VBOX_FAILURE(rc))