Changeset 16337 in vbox for trunk/src/VBox/HostServices/GuestProperties

Timestamp:

Jan 28, 2009 9:03:49 PM (16 years ago)

Author:

vboxsync

Message:

gcc warning (strncat may overflow)

File:

• trunk/src/VBox/HostServices/GuestProperties/testcase/tstGuestPropSvc.cpp (modified) (3 diffs)

trunk/src/VBox/HostServices/GuestProperties/testcase/tstGuestPropSvc.cpp

@@ -454 +454 @@
         /* Work around silly constant issues - we ought to allow passing
          * constant strings in the hgcm parameters. */
-        char szName[MAX_NAME_LEN] = "";
-        char szValue[MAX_VALUE_LEN] = "";
-        char szFlags[MAX_FLAGS_LEN] = "";
-        strncat(szName, setProperties[i].pcszName, sizeof(szName));
-        strncat(szValue, setProperties[i].pcszValue, sizeof(szValue));
-        strncat(szFlags, setProperties[i].pcszFlags, sizeof(szFlags));
+        char szName[MAX_NAME_LEN];
+        char szValue[MAX_VALUE_LEN];
+        char szFlags[MAX_FLAGS_LEN];
+        RTStrPrintf(szName, sizeof(szName), "%s", setProperties[i].pcszName);
+        RTStrPrintf(szValue, sizeof(szValue), "%s", setProperties[i].pcszValue);
+        RTStrPrintf(szFlags, sizeof(szFlags), "%s", setProperties[i].pcszFlags);
         paParms[0].setPointer (szName, (uint32_t)strlen(szName) + 1);
         paParms[1].setPointer (szValue, (uint32_t)strlen(szValue) + 1);
@@ -530 +530 @@
         /* Work around silly constant issues - we ought to allow passing
          * constant strings in the hgcm parameters. */
-        char szName[MAX_NAME_LEN] = "";
-        strncat(szName, delProperties[i].pcszName, sizeof(szName));
+        char szName[MAX_NAME_LEN];
+        RTStrPrintf(szName, sizeof(szName), "%s", delProperties[i].pcszName);
         paParms[0].setPointer (szName, (uint32_t)strlen(szName) + 1);
         if (delProperties[i].isHost)
@@ -608 +608 @@
         AssertBreakStmt(sizeof(szBuffer) >= getProperties[i].cchValue,
                         rc = VERR_INTERNAL_ERROR);
-        strncat(szName, getProperties[i].pcszName, sizeof(szName));
+        RTStrPrintf(szName, sizeof(szName), "%s", getProperties[i].pcszName);
         paParms[0].setPointer (szName, (uint32_t)strlen(szName) + 1);
         paParms[1].setPointer (szBuffer, sizeof(szBuffer));