Changeset 16589 in vbox for trunk

Timestamp:

Feb 9, 2009 2:16:19 PM (16 years ago)

Author:

vboxsync

Message:

FE/Qt4: 3576: Warn if VT-x/AMD-V is not functional. Implemented auto-enabling warning in VM Settings & virtualization-failed warning during VM starting.

Location:

trunk/src/VBox/Frontends/VirtualBox

Files:

• include/VBoxConsoleWnd.h (modified) (1 diff)
• include/VBoxProblemReporter.h (modified) (1 diff)
• include/VBoxVMSettingsGeneral.h (modified) (2 diffs)
• src/VBoxConsoleWnd.cpp (modified) (2 diffs)
• src/VBoxProblemReporter.cpp (modified) (1 diff)
• src/VBoxVMSettingsGeneral.cpp (modified) (5 diffs)

trunk/src/VBox/Frontends/VirtualBox/include/VBoxConsoleWnd.h

@@ -184 +184 @@
     bool toggleFullscreenMode (bool, bool);
 
+    void checkRequiredFeatures();
+
 private slots:
 

trunk/src/VBox/Frontends/VirtualBox/include/VBoxProblemReporter.h

@@ -233 +233 @@
 
     void cannotSendACPIToMachine();
+    bool warnAboutVirtNotEnabled();
 
     void cannotSetSnapshotFolder (const CMachine &aMachine, const QString &aPath);

trunk/src/VBox/Frontends/VirtualBox/include/VBoxVMSettingsGeneral.h

@@ -46 +46 @@
     void putBackTo();
 
+    void setValidator (QIWidgetValidator *aVal);
     bool revalidate (QString &aWarning, QString &aTitle);
 
@@ -75 +76 @@
 
     CMachine mMachine;
+    QIWidgetValidator *mValidator;
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/VBoxConsoleWnd.cpp

@@ -1094 +1094 @@
 #endif
 
+    /* Finally check the status of required features. */
+    checkRequiredFeatures();
+
     /* Re-request all the static values finally after
      * view is really opened and attached. */
@@ -2139 +2142 @@
 
 /**
+ *  This function checks the status of required features and
+ *  makes a warning and/or some action if something necessary
+ *  is not in good condition.
+ *  Does nothing if no console view was opened.
+ */
+void VBoxConsoleWnd::checkRequiredFeatures()
+{
+    if (!console) return;
+
+    CConsole cconsole = console->console();
+
+    /* Check if virtualization feature enabled for 64 bits guest */
+    bool is64BitsGuest = vboxGlobal().virtualBox().GetGuestOSType (
+                         cconsole.GetGuest().GetOSTypeId()).GetIs64Bit();
+    bool isVirtEnabled = cconsole.GetDebugger().GetHWVirtExEnabled();
+    if (is64BitsGuest && !isVirtEnabled)
+    {
+        vmPause (true);
+        vboxProblem().warnAboutVirtNotEnabled() ? close() : vmPause (false);
+    }
+}
+
+/**
  * @return @c true if successfully performed the requested operation and false
  * otherwise.

trunk/src/VBox/Frontends/VirtualBox/src/VBoxProblemReporter.cpp

@@ -930 +930 @@
 }
 
+bool VBoxProblemReporter::warnAboutVirtNotEnabled()
+{
+    return messageOkCancel (mainWindowShown(), Error,
+        tr ("<p>VT-x/AMD-V hardware acceleration has been enabled, but is "
+            "not operational. Your 64 bits guest will fail to detect a 64 "
+            "bits CPU and will not be able to boot.</p><p>Please check if you "
+            "have enabled VT-x/AMD-V properly in the BIOS of your host "
+            "computer.</p>"),
+        0 /* aAutoConfirmId */,
+        tr ("Close VM"), tr ("Continue"));
+}
+
 void VBoxProblemReporter::cannotSetSnapshotFolder (const CMachine &aMachine,
                                                    const QString &aPath)

trunk/src/VBox/Frontends/VirtualBox/src/VBoxVMSettingsGeneral.cpp

@@ -24 +24 @@
 #include "VBoxGlobal.h"
 #include "VBoxProblemReporter.h"
+#include "QIWidgetValidator.h"
 #include <iprt/asm.h>
 #include <VBox/x86.h>
@@ -52 +53 @@
 
 VBoxVMSettingsGeneral::VBoxVMSettingsGeneral()
+    : mValidator (0)
 {
     /* Apply UI decorations */
@@ -240 +242 @@
     QString saveRtimeImages = mMachine.GetExtraData (VBoxDefs::GUI_SaveMountedAtRuntime);
     mCbSaveMounted->setChecked (saveRtimeImages != "no");
+
+    if (mValidator)
+        mValidator->revalidate();
 }
 
 void VBoxVMSettingsGeneral::putBackTo()
 {
+    /* Make auto-attenuation for some settings in this chapter: */
+
+    /* Enable VT-x/AMD-V feature if the guest is of 64 bits */
+    if (mOSTypeSelector->type().GetIs64Bit())
+        mCbVirt->setChecked (true);
+
+    /* Save user's predefined settings in this chapter: */
+
     CBIOSSettings biosSettings = mMachine.GetBIOSSettings();
 
@@ -327 +340 @@
 }
 
+void VBoxVMSettingsGeneral::setValidator (QIWidgetValidator *aVal)
+{
+    mValidator = aVal;
+    connect (mCbVirt, SIGNAL (stateChanged (int)), mValidator, SLOT (revalidate()));
+    connect (mOSTypeSelector, SIGNAL (osTypeChanged()), mValidator, SLOT (revalidate()));
+}
+
 bool VBoxVMSettingsGeneral::revalidate (QString &aWarning, QString & /* aTitle */)
 {
+    /* System RAM & Video RAM sliders correlation test */
     ulong fullSize = vboxGlobal().virtualBox().GetHost().GetMemorySize();
     quint64 needBytes = VBoxGlobal::requiredVideoMemory (&mMachine);
-
     if (mSlRam->value() + mSlVideo->value() > 0.75 * fullSize)
     {
@@ -359 +379 @@
         return true;
     }
+
+    /* Guest OS type & VT-x/AMD-V option correlation test */
+    if (mOSTypeSelector->type().GetIs64Bit() && !mCbVirt->isChecked())
+    {
+        aWarning = tr (
+            "there is a 64 bits guest OS type assigned for this VM, which "
+            "requires virtualization feature (VT-x/AMD-V) to be enabled "
+            "too, else your guest will fail to detect a 64 bits CPU and "
+            "will not be able to boot, so this feature will be enabled "
+            "automatically when you'll accept VM Settings by pressing OK "
+            "button.");
+        return true;
+    }
+
     return true;
 }