Changeset 16655 in vbox for trunk

Timestamp:

Feb 11, 2009 11:05:54 AM (16 years ago)

Author:

vboxsync

Message:

OVF: Make the progress object show some progress.

File:

• trunk/src/VBox/Main/ApplianceImpl.cpp (modified) (12 diffs)

trunk/src/VBox/Main/ApplianceImpl.cpp

@@ -251 +251 @@
     ComObjPtr<Appliance> appliance;
     appliance.createObject();
+    /* @todo r=poetzsch: We should consider to split the creation & opening of
+       the appliance into two calls. Now the returned appliance is null in the
+       case of an error. But at the same time the error message is in the
+       appliance object which isn't returned. So I propose: createAppliance in
+       IVirtualBox & OpenAppliance in IAppliance. Such an error could easily
+       produced if you set an invalid path to the open call. */
     rc = appliance->init(this, bstrPath);
 //     ComAssertComRCThrowRC(rc);
@@ -1545 +1551 @@
     try
     {
+        /* Figure out how many sub operation the import will need */
+        /* One for the appliance */
+        int opCount = 1;
+        list< ComObjPtr<VirtualSystemDescription> >::const_iterator it;
+        for (it = m->virtualSystemDescriptions.begin();
+             it != m->virtualSystemDescriptions.end();
+             ++it)
+        {
+            /* One for every Virtual System */
+            ++opCount;
+            ComObjPtr<VirtualSystemDescription> vsdescThis = (*it);
+            /* One for every hard disk of the Virtual System */
+            std::list<VirtualSystemDescriptionEntry*> avsdeHDs = vsdescThis->findByType(VirtualSystemDescriptionType_HardDiskImage);
+            opCount += avsdeHDs.size();
+        }
+        Bstr progressDesc = BstrFmt(tr("Import appliance '%ls'"),
+                                    m->bstrPath.raw());
         /* Create the progress object */
         progress.createObject();
         rc = progress->init(mVirtualBox, static_cast<IAppliance *>(this),
-                            BstrFmt(tr("Import appliance '%ls'"),
-                                    m->bstrPath.raw()),
-                            FALSE /* aCancelable */);
+                            progressDesc,
+                            FALSE /* aCancelable */,
+                            opCount,
+                            progressDesc);
         CheckComRCThrowRC(rc);
 
@@ -1638 +1662 @@
     HRESULT rc = S_OK;
 
-    /* For now we report 2 steps for every virtual system. Later we may add the
-       progress of the image cloning. */
-    float opCountMax = (float)100.0 / (app->m->llVirtualSystems.size() * 2);
-    uint32_t opCount = 0;
-
     list<VirtualSystem>::const_iterator it;
     list< ComObjPtr<VirtualSystemDescription> >::const_iterator it1;
@@ -1658 +1677 @@
         try
         {
+            if (!task->progress.isNull())
+            {
+                rc = task->progress->advanceOperation (BstrFmt(tr("Importing Virtual System %d"), i + 1));
+                CheckComRCThrowRC(rc);
+            }
+
+            /* How many sub notifications are necessary? */
+            const float opCountMax = 100.0/5;
+            uint32_t opCount = 0;
+
             /* Guest OS type */
             std::list<VirtualSystemDescriptionEntry*> vsdeOS = vsdescThis->findByType(VirtualSystemDescriptionType_OS);
@@ -1679 +1708 @@
             CheckComRCThrowRC(rc);
 
+            if (!task->progress.isNull())
+            {
+                rc = task->progress->notifyProgress(opCountMax * opCount++);
+                CheckComRCThrowRC(rc);
+            }
+
             /* CPU count (ignored for now) */
             // EntriesList vsdeCPU = vsd->findByType (VirtualSystemDescriptionType_CPU);
@@ -1698 +1733 @@
             rc = pNewMachine->COMSETTER(VRAMSize)(vramVBox);
             CheckComRCThrowRC(rc);
+
+            if (!task->progress.isNull())
+            {
+                rc = task->progress->notifyProgress(opCountMax * opCount++);
+                CheckComRCThrowRC(rc);
+            }
 
             /* Audio Adapter */
@@ -1729 +1770 @@
             rc = usbController->COMSETTER(Enabled)(fUSBEnabled);
             CheckComRCThrowRC(rc);
+
+            if (!task->progress.isNull())
+            {
+                rc = task->progress->notifyProgress(opCountMax * opCount++);
+                CheckComRCThrowRC(rc);
+            }
 
             /* Change the network adapters */
@@ -1776 +1823 @@
             CheckComRCThrowRC(rc);
 
+            if (!task->progress.isNull())
+            {
+                rc = task->progress->notifyProgress(opCountMax * opCount++);
+                CheckComRCThrowRC(rc);
+            }
+
             /* CDROM drive */
             /* @todo: I can't disable the CDROM. So nothing to do for now */
@@ -1838 +1891 @@
 
             if (!task->progress.isNull())
-                task->progress->notifyProgress(static_cast<ULONG>(opCountMax * opCount++));
+            {
+                rc = task->progress->notifyProgress(opCountMax * opCount++);
+                CheckComRCThrowRC(rc);
+            }
 
             /* Create the hard disks & connect them to the appropriate controllers. */
@@ -1918 +1974 @@
                             dstHdVBox->CreateDynamicStorage(di.iCapacity / _1M, progress.asOutParam());
                             CheckComRCThrowRC(rc);
-                            rc = progress->WaitForCompletion(-1);
+                            /* Advance to the next operation */
+                            if (!task->progress.isNull())
+                            {
+                                rc = task->progress->advanceOperation (BstrFmt(tr("Creating virtual disk image '%s'"), pcszDstFilePath));
+                                CheckComRCThrowRC(rc);
+                            }
+                            /* Manually check the progress to inform the user */
+                            BOOL fCompleted;
+                            LONG currentPercent;
+                            while (SUCCEEDED(progress->COMGETTER(Completed(&fCompleted))))
+                            {
+                                 rc = progress->COMGETTER(Percent(&currentPercent));
+                                 CheckComRCThrowRC(rc);
+                                 if (!task->progress.isNull())
+                                 {
+                                     rc = task->progress->notifyProgress(currentPercent);
+                                     CheckComRCThrowRC(rc);
+                                 }
+                                 if (fCompleted)
+                                     break;
+                                 /* Make sure the loop is not too tight */
+                                 rc = progress->WaitForCompletion(100);
+                                 CheckComRCThrowRC(rc);
+                            }
+                            /* Check the real return code of the asynchrony operation */
+                            HRESULT vrc;
+                            rc = progress->COMGETTER(ResultCode)(&vrc);
                             CheckComRCThrowRC(rc);
+                            CheckComRCThrowRC(vrc);
                         }
                         else
@@ -1948 +2031 @@
                             rc = srcHdVBox->CloneTo(dstHdVBox, progress.asOutParam());
                             CheckComRCThrowRC(rc);
-                            rc = progress->WaitForCompletion(-1);
+                            /* Advance to the next operation */
+                            if (!task->progress.isNull())
+                            {
+                                rc = task->progress->advanceOperation (BstrFmt(tr("Importing virtual disk image '%s'"), strSrcFilePath.c_str()));
+                                CheckComRCThrowRC(rc);
+                            }
+                            /* Manually check the progress to inform the user */
+                            BOOL fCompleted;
+                            LONG currentPercent;
+                            while (SUCCEEDED(progress->COMGETTER(Completed(&fCompleted))))
+                            {
+                                 rc = progress->COMGETTER(Percent(&currentPercent));
+                                 CheckComRCThrowRC(rc);
+                                 if (!task->progress.isNull())
+                                 {
+                                     rc = task->progress->notifyProgress (currentPercent);
+                                     CheckComRCThrowRC(rc);
+                                 }
+                                 if (fCompleted)
+                                     break;
+                                 /* Make sure the loop is not too tight */
+                                 rc = progress->WaitForCompletion(100);
+                                 CheckComRCThrowRC(rc);
+                            }
+                            /* Check the real return code of the asynchrony operation */
+                            HRESULT vrc;
+                            rc = progress->COMGETTER(ResultCode)(&vrc);
                             CheckComRCThrowRC(rc);
+                            CheckComRCThrowRC(vrc);
                             /* We *must* close the source disk image in order to deregister it */
                             rc = srcHdVBox->Close();
@@ -2003 +2113 @@
                     rc = failedMachine->DeleteSettings();
                     CheckComRCThrowRC(rc);
-                    /* Throw the original error number */
-                    throw aRC;
+                    /* Throw the original error */
+                    throw;
                 }
             }
-            if (!task->progress.isNull())
-                task->progress->notifyProgress(static_cast<ULONG>(opCountMax * opCount++));
         }
         catch(HRESULT aRC)
         {
             /* @todo: If we are here an error on importing of *one* virtual
-               system has occured. We didn't break now, but try to import the
+               system has occurred. We didn't break now, but try to import the
                other virtual systems. This needs some further discussion. */
             rc = aRC;