Changeset 1672 in kBuild

Timestamp:

Jul 7, 2008 9:38:57 PM (17 years ago)

Author:

bird

Message:

Global USES differs from target USES and must be executed before any inherting because they may add target properties. Added a unit callout prior to source processing.

File:

• trunk/kBuild/footer.kmk (modified) (7 diffs)

trunk/kBuild/footer.kmk

@@ -613 +613 @@
 
 endef # def_inherit
+
+
+#
+# Load global units before doing any inheriting so they can add new properties.
+#
+# This only applies to the guys listed in the global USES since there is
+# no reliable way to deal with things on a target level without first
+# applying templates. So, to avoid having USES mess up all targets,
+# we'll make the global and per-target USES property work differently:
+#     The global USES does not apply to targets, just globally.
+#
+
+## Unit load function.
+# @param loading    The unit name
+define def_unit_load_function
+ifndef UNIT_$(loading)
+ UNIT_$(loading)_KMK_FILE := $(firstword $(foreach path, $(KBUILD_UNIT_PATHS) $(KBUILD_PATH)/units $(KBUILD_DEFAULT_PATHS), $(wildcard $(path)/$(loading).kmk)))
+ ifeq ($(UNIT_$(loading)_KMK_FILE),)
+  $(error kBuild: Cannot find include file for the unit '$(loading)'! Searched: $(KBUILD_UNIT_PATHS) $(KBUILD_PATH)/units $(KBUILD_DEFAULT_PATHS))
+ endif
+ include $(UNIT_$(loading)_KMK_FILE)
+ ifndef UNIT_$(loading)
+  $(warning kBuild: UNIT_$(loading) was not defined by $(UNIT_$(loading)_KMK_FILE)!)
+ endif
+endif
+endef # def_unit_load_function
+
+$(foreach loading, \
+        $(USES.$(KBUILD_TARGET).$(KBUILD_TARGET_ARCH)) \
+        $(USES.$(KBUILD_TARGET_CPU)) \
+        $(USES.$(KBUILD_TARGET_ARCH)) \
+        $(USES.$(KBUILD_TARGET)) \
+        $(USES.$(KBUILD_HOST).$(KBUILD_HOST_ARCH)) \
+        $(USES.$(KBUILD_HOST_CPU)) \
+        $(USES.$(KBUILD_HOST_ARCH)) \
+        $(USES.$(KBUILD_TARGET)) \
+        $(USES.$(KBUILD_TYPE)) \
+        $(USES),$(evalval def_unit_load_function))
 
 
@@ -1213 +1251 @@
 endef # def_sdk_load_function
 
-## Unit load function.
-# @param loading    The unit name
-define def_unit_load_function
-ifndef UNIT_$(loading)
- UNIT_$(loading)_KMK_FILE := $(firstword $(foreach path, $(KBUILD_UNIT_PATHS) $(KBUILD_PATH)/units $(KBUILD_DEFAULT_PATHS), $(wildcard $(path)/$(loading).kmk)))
- ifeq ($(UNIT_$(loading)_KMK_FILE),)
-  $(error kBuild: Cannot find include file for the unit '$(loading)'! Searched: $(KBUILD_UNIT_PATHS) $(KBUILD_PATH)/units $(KBUILD_DEFAULT_PATHS))
- endif
- include $(UNIT_$(loading)_KMK_FILE)
- ifndef UNIT_$(loading)
-  $(warning kBuild: UNIT_$(loading) was not defined by $(UNIT_$(loading)_KMK_FILE)!)
- endif
-endif
-endef # def_unit_load_function
-
 
 properties :=
@@ -1306 +1329 @@
  PATH_$(target) := $(patsubst %/,%,$(dir $(outbase)))
 else ifneq ($(PATH_$(target)),$(patsubst %/,%,$(dir $(outbase))))
-  $(error kBuild internal error: PATH_$(target)=$(PATH_$(target)) expected $(patsubst %/,%,$(dir $(outbase))))
+ $(error kBuild internal error: PATH_$(target)=$(PATH_$(target)) expected $(patsubst %/,%,$(dir $(outbase))))
 endif
 ifeq ($(tool_prefix),AR) ## @todo fix this mess!
@@ -2130 +2153 @@
 ifndef PATH_$(target)
  PATH_$(target)   := $(patsubst %/,%,$(dir $(outbase)))
-else
- ifneq ($(PATH_$(target)),$(patsubst %/,%,$(dir $(outbase))))
-  $(error kBuild internal error: PATH_$(target)=$(PATH_$(target)) expected $(patsubst %/,%,$(dir $(outbase))))
- endif
+else ifneq ($(PATH_$(target)),$(patsubst %/,%,$(dir $(outbase))))
+ $(error kBuild internal error: PATH_$(target)=$(PATH_$(target)) expected $(patsubst %/,%,$(dir $(outbase))))
 endif
 local suff        := $(firstword\
@@ -2149 +2170 @@
 othersrc          :=
 $(target)_OBJS_   :=
+
+# Do units pre source callouts.
+local units       := \
+        $($(target)_USES.$(bld_trg).$(bld_trg_arch))\
+        $($(target)_USES.$(bld_trg_arch))\
+        $($(target)_USES.$(bld_trg))\
+        $($(target)_USES.$(bld_type))\
+        $($(target)_USES)
+$(foreach unit,$(units),$(evalval def_unit_$(unit)_target_pre))
 
 # source -> object
@@ -2341 +2371 @@
 ifndef PATH_$(target)
  PATH_$(target)   := $(patsubst %/,%,$(dir $(outbase)))
-else
- ifneq ($(PATH_$(target)),$(patsubst %/,%,$(dir $(outbase))))
-  $(error kBuild internal error: PATH_$(target)=$(PATH_$(target)) expected $(patsubst %/,%,$(dir $(outbase))))
- endif
+else ifneq ($(PATH_$(target)),$(patsubst %/,%,$(dir $(outbase))))
+ $(error kBuild internal error: PATH_$(target)=$(PATH_$(target)) expected $(patsubst %/,%,$(dir $(outbase))))
 endif
 local suff        := $(firstword \
@@ -2357 +2385 @@
 othersrc          :=
 $(target)_OBJS_   :=
+
+# Do units pre source callouts.
+local units       := \
+        $($(target)_USES.$(bld_trg).$(bld_trg_arch))\
+        $($(target)_USES.$(bld_trg_arch))\
+        $($(target)_USES.$(bld_trg))\
+        $($(target)_USES.$(bld_type))\
+        $($(target)_USES)
+$(foreach unit,$(units),$(evalval def_unit_$(unit)_target_pre))
 
 # source -> object