Changeset 16807 in vbox for trunk/src/VBox/Runtime/common

Timestamp:

Feb 17, 2009 1:28:22 AM (16 years ago)

Author:

vboxsync

Message:

RTErrConvertToErrno: VERR_PATH_NOT_FOUND -> ENOTDIR like RTErrConvertFromErrno does, not ENOENT. Iff this was done intentionally, then let me know!

File:

• trunk/src/VBox/Runtime/common/err/RTErrConvertToErrno.cpp (modified) (3 diffs)

trunk/src/VBox/Runtime/common/err/RTErrConvertToErrno.cpp

@@ -55 +55 @@
      * Process error codes.
      *
-     * Try to reverse the behaviour of RTErrConvertFromErrno as far
-     * as possible.
+     * (Use a switch and not a table since the numbers vary among compilers
+     * and OSes. So we let the compiler switch optimizer handle speed issues.)
      *
-     * @note I am very impressed by the length of some of these
-     *       error codes - we have obviously learnt something from
-     *       Unix's failings :)
+     * This switch is arranged like the Linux i386 errno.h! It also mirrors the
+     * conversions performed by RTErrConvertFromErrno with a few extra case since
+     * there are far more IPRT status codes than Unix ones.
      */
     switch (iErr)
@@ -92 +92 @@
 #endif
 #ifdef ECHILD
-        //case VERR_PROCESS_NOT_FOUND:                return ECHILD;
+        case VERR_PROCESS_NOT_FOUND:                return ECHILD;
 #endif
 #ifdef EAGAIN
@@ -122 +122 @@
 #endif
 #ifdef ENOTDIR
-        case VERR_PATH_NOT_FOUND:                   return ENOENT;
+        case VERR_NOT_A_DIRECTORY:
+        case VERR_PATH_NOT_FOUND:                   return ENOTDIR;
 #endif
 #ifdef EISDIR