Changeset 16839 in vbox

Timestamp:

Feb 17, 2009 1:24:19 PM (16 years ago)

Author:

vboxsync

Message:

properly detect gcc<=3.3 for recompiler_new (intern issue #3649)

Location:

trunk

Files:

• Config.kmk (modified) (1 diff)
• src/recompiler_new/Makefile.kmk (modified) (1 diff)

trunk/Config.kmk

@@ -1586 +1586 @@
         $(APPEND) '$@' 'VBOX_GCC_mtune-generic         ?= $(call VBOX_GCC_CHECK_CC,-mtune=generic,)'
         $(APPEND) '$@' 'VBOX_LD_as_needed              ?= $(call VBOX_GCC_CHECK_LD,--as-needed,)'
+# gcc version < 3.4 has a bug in handling __attribute__((regparm(3))).
+# See http://osdir.com/ml/gcc.prs/2002-08/msg00223.html and probably http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20004
+        $(APPEND) '$@' 'ifneq ($$(int-lt $$(VBOX_GCC_VERSION_CC),30400),)'
+        $(APPEND) '$@' ' VBOX_GCC_BUGGY_REGPARM        ?= 1'
+        $(APPEND) '$@' 'endif'
 ifneq ($(KBUILD_TARGET),l4)
 # Set default attribute for ELF and MACH-O symbols to ``hidden'' to reduce the number

trunk/src/recompiler_new/Makefile.kmk

@@ -100 +100 @@
 $(REM_MOD)_CFLAGS.profile  = $($(REM_MOD)_CFLAGS.release)
 $(REM_MOD)_DEFS           += IN_RING3 $(ARCH_BITS_DEFS)
-# Temporary hack, to allow running with oldish GCC
+# workaround the regparm bug in gcc <= 3.3
 $(REM_MOD)_DEFS.win.x86   += GCC_WITH_BUGGY_REGPARM
 else  # !win
 $(REM_MOD)_TEMPLATE        = VBOXR3NP
-$(REM_MOD)_DEFS            =
+# workaround the regparm bug in gcc <= 3.3
+$(REM_MOD)_DEFS            = $(if $(VBOX_GCC_BUGGY_REGPARM),GCC_WITH_BUGGY_REGPARM,)
 endif # !win
 $(REM_MOD)_DEFS           += IN_REM_R3 REM_INCLUDE_CPU_H