VirtualBox

Ignore:
Timestamp:
Feb 27, 2009 12:37:35 AM (16 years ago)
Author:
vboxsync
svn:sync-xref-src-repo-rev:
43470
Message:

VBoxNetFlt: review of core changes, several review comments needing follow up. untested

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/VBox/HostDrivers/VBoxNetFlt/linux/VBoxNetFlt-linux.c

    r17062 r17184  
    9999        flags = (dev->flags & ~(IFF_PROMISC |
    100100                                IFF_ALLMULTI |
    101                                 IFF_RUNNING)) | 
     101                                IFF_RUNNING)) |
    102102                (dev->gflags & (IFF_PROMISC |
    103103                                IFF_ALLMULTI));
     
    209209{
    210210    Log(("vboxTapValidateAddr: %02x:%02x:%02x:%02x:%02x:%02x\n",
    211          dev->dev_addr[0], dev->dev_addr[1], dev->dev_addr[2], 
     211         dev->dev_addr[0], dev->dev_addr[1], dev->dev_addr[2],
    212212         dev->dev_addr[3], dev->dev_addr[4], dev->dev_addr[5]));
    213213    return -EADDRNOTAVAIL;
     
    221221    /// @todo Use Sun vendor id
    222222    memcpy(pNetDev->dev_addr, "\0vbnet", ETH_ALEN);
    223     Log(("vboxTapNetDevInit: pNetDev->dev_addr = %.6Rhxd\n", pNetDev->dev_addr)); 
     223    Log(("vboxTapNetDevInit: pNetDev->dev_addr = %.6Rhxd\n", pNetDev->dev_addr));
    224224    pNetDev->open = vboxTapOpen;
    225225    pNetDev->stop = vboxTapStop;
     
    297297         */
    298298        memset(&g_VBoxNetFltGlobals, 0, sizeof(g_VBoxNetFltGlobals));
    299         rc = vboxNetFltInitGlobals(&g_VBoxNetFltGlobals);
     299        rc = vboxNetFltInitGlobalsAndIdc(&g_VBoxNetFltGlobals);
    300300        if (RT_SUCCESS(rc))
    301301        {
     
    337337    rc = vboxTapUnregisterNetDev();
    338338    AssertRC(rc);
    339     rc = vboxNetFltTryDeleteGlobals(&g_VBoxNetFltGlobals);
     339    rc = vboxNetFltTryDeleteIdcAndGlobals(&g_VBoxNetFltGlobals);
    340340    AssertRC(rc); NOREF(rc);
    341341
     
    598598    if (!pBuf)
    599599        return 0;
    600    
     600
    601601    pThis = VBOX_FLT_PT_TO_INST(pPacketType);
    602602    pDev = (struct net_device *)ASMAtomicUoReadPtr((void * volatile *)&pThis->u.s.pDev);
     
    669669    }
    670670#endif
    671            
     671
    672672    dev_kfree_skb(pBuf);
    673673}
     
    10881088        {
    10891089            if (pThis->u.s.fPromiscuousSet)
    1090             {   
     1090            {
    10911091                rtnl_lock();
    10921092                dev_set_promiscuity(pDev, -1);
Note: See TracChangeset for help on using the changeset viewer.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette