Changeset 17193 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

Feb 27, 2009 10:00:17 AM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

43484

Message:

Revert r43482 which used a linux specific way to iterate over DVD drives.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• VBoxConsoleWnd.cpp (modified) (2 diffs)
• VBoxVMFirstRunWzd.cpp (modified) (4 diffs)
• VBoxVMSettingsCD.cpp (modified) (4 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/VBoxConsoleWnd.cpp

@@ -6 +6 @@
 
 /*
- * Copyright (C) 2006-2009 Sun Microsystems, Inc.
+ * Copyright (C) 2006-2008 Sun Microsystems, Inc.
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -3133 +3133 @@
 
     hostDVDMap.clear();
-    CHostDVDDriveVector drvvec =
-        vboxGlobal().virtualBox().GetHost().GetDVDDrives();
-    for (int i = 0; i < drvvec.size(); ++i)
-    {
-        CHostDVDDrive hostDVD = drvvec[i];
+    CHostDVDDriveEnumerator en =
+        vboxGlobal().virtualBox().GetHost().GetDVDDrives().Enumerate();
+    while (en.HasMore())
+    {
+        CHostDVDDrive hostDVD = en.GetNext();
         /** @todo set icon */
         QString drvName = hostDVD.GetName();

trunk/src/VBox/Frontends/VirtualBox/src/VBoxVMFirstRunWzd.cpp

@@ -6 +6 @@
 
 /*
- * Copyright (C) 2006-2009 Sun Microsystems, Inc.
+ * Copyright (C) 2006-2008 Sun Microsystems, Inc.
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -176 +176 @@
     {
         /* Search for the host dvd-drives */
-        CHostDVDDriveVector coll =
+        CHostDVDDriveCollection coll =
             vboxGlobal().virtualBox().GetHost().GetDVDDrives();
-        mHostDVDs.resize (coll.size());
-
-        for (int id = 0; id < coll.size(); ++id)
-        {
-            CHostDVDDrive hostDVD = coll[id];
+        mHostDVDs.resize (coll.GetCount());
+        int id = 0;
+        CHostDVDDriveEnumerator en = coll.Enumerate();
+        while (en.HasMore())
+        {
+            CHostDVDDrive hostDVD = en.GetNext();
             QString name = hostDVD.GetName();
             QString description = hostDVD.GetDescription();
@@ -189 +190 @@
             mCbHost->insertItem (id, fullName);
             mHostDVDs [id] = hostDVD;
+            ++ id;
         }
 
@@ -220 +222 @@
 
     /* Repopulate the media list */
-    mCbImage->repopulate();
+        mCbImage->repopulate();
 
     /* Revalidate updated page */

trunk/src/VBox/Frontends/VirtualBox/src/VBoxVMSettingsCD.cpp

@@ -6 +6 @@
 
 /*
- * Copyright (C) 2006-2009 Sun Microsystems, Inc.
+ * Copyright (C) 2006-2008 Sun Microsystems, Inc.
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -59 +59 @@
 
     /* Read out the host DVD drive list and prepare the combobox */
-    CHostDVDDriveVector coll =
+    CHostDVDDriveCollection coll =
         vboxGlobal().virtualBox().GetHost().GetDVDDrives();
-    mHostCDs.resize (coll.size());
+    mHostCDs.resize (coll.GetCount());
     mCbHostCD->clear();
-
-    for (int id = 0; id < coll.size(); ++id)
-    {
-        CHostDVDDrive hostDVD = coll[id];
+    int id = 0;
+    CHostDVDDriveEnumerator en = coll.Enumerate();
+    while (en.HasMore())
+    {
+        CHostDVDDrive hostDVD = en.GetNext();
         /// @todo (r=dmik) set icon?
         QString name = hostDVD.GetName();
@@ -74 +75 @@
         mCbHostCD->insertItem (id, fullName);
         mHostCDs [id] = hostDVD;
+        ++ id;
     }
 
@@ -87 +89 @@
                 name :
                 QString ("%1 (%2)").arg (description, name);
-            if (vboxGlobal().virtualBox().GetHost().FindHostDVDDrive (name).isNull())
+            if (coll.FindByName (name).isNull())
             {
                 /* If the DVD drive is not currently available,