Changeset 17244 in vbox for trunk/src/VBox/HostDrivers/VBoxNetFlt

Timestamp:

Mar 2, 2009 11:34:49 AM (16 years ago)

Author:

vboxsync

Message:

NetFlt/NetAdp: enabled new construct/distruct sinchronization

File:

• trunk/src/VBox/HostDrivers/VBoxNetFlt/VBoxNetFlt.c (modified) (5 diffs)

trunk/src/VBox/HostDrivers/VBoxNetFlt/VBoxNetFlt.c

@@ -228 +228 @@
 #include <iprt/time.h>
 #include <iprt/semaphore.h>
+#include <iprt/thread.h>
 
 
@@ -645 +646 @@
      */
     rc = RTSemFastMutexRequest(pGlobals->hFastMtx); AssertRC(rc);
-#ifdef VBOXNETFLT_STATIC_CONFIG
+#if 0 //#ifdef VBOXNETFLT_STATIC_CONFIG
 /** @todo r=bird: This looks kind of insane! I ASSUME this is specific to the
  * static config and to devices in the Unconnected state only. This *looks* like
@@ -996 +997 @@
     PINTNETTRUNKIFPORT pIfPort;
     PVBOXNETFLTINS pCur;
+    VBOXNETFTLINSSTATE enmState;
     int rc;
 
@@ -1016 +1018 @@
     while (pCur)
     {
-#if 0
+#if 1
         uint32_t cRefs = ASMAtomicIncU32(&pCur->cRefs);
         if (cRefs > 1)
         {
-            VBOXNETFTLINSSTATE enmState = vboxNetFltGetState(pCur);
+            enmState = vboxNetFltGetState(pCur);
             switch (enmState)
             {
@@ -1157 +1159 @@
     {
 #ifdef VBOXNETFLT_STATIC_CONFIG
-# if 0 /** @todo r=bird: We need to fix the race here. The race is against release+destructor, the
+# if 1 /** @todo r=bird: We need to fix the race here. The race is against release+destructor, the
         * tell tale is a cRefs of and since cRefs is manipulated in an atomic fashion we can simply attempt
         * to grab a reference atomically, the worst thing that can happen is that we have to decrement it again..