Changeset 1727 in kBuild for trunk/src/kmk

Timestamp:

Sep 5, 2008 1:45:52 AM (16 years ago)

Author:

bird

Message:

kmk: Two new functions $(if-expr cond,exp-on-true,exp-on-false) and $(expr expression) that uses the expreval.c expression evaluator.

Location:

trunk/src/kmk

Files:

• function.c (modified) (4 diffs)
• testcase-ifcond.kmk (modified) (7 diffs)

trunk/src/kmk/function.c

@@ -2724 +2724 @@
     if (e1 - s1 != e2 - s2)
       return comp_vars_ne (o, s1, e1, s2, e2, argv[2], funcname);
-l_simple_compare:
     if (!memcmp (s1, s2, e1 - s1))
       return variable_buffer_output (o, "", 0);     /* eq */
@@ -3089 +3088 @@
   return variable_buffer_output (o, "", 0);
 }
-#endif
+#endif /* CONFIG_WITH_WHICH */
+
+#ifdef CONFIG_WITH_IF_CONDITIONALS
+
+/* Evaluates the expression given in the argument using the
+   same evaluator as for the new 'if' statements, except now
+   we don't force the result into a boolean like for 'if' and
+   '$(if-expr ,,)'. */
+static char *
+func_expr (char *o, char **argv, const char *funcname UNUSED)
+{
+  o = expr_eval_to_string (o, argv[0]);
+  return o;
+}
+
+/* Same as '$(if ,,)' except the first argument is evaluated
+   using the same evaluator as for the new 'if' statements. */
+static char *
+func_if_expr (char *o, char **argv, const char *funcname UNUSED)
+{
+    int rc;
+    char *to_expand;
+
+    /* Evaluate the condition in argv[0] and expand the 2nd or
+       3rd argument according to the result. */
+    rc = expr_eval_if_conditionals (argv[0], NULL);
+    to_expand = rc == 0 ? argv[1] : argv[2];
+    if (*to_expand)
+      {
+        char *expansion = expand_argument (to_expand, NULL);
+
+        o = variable_buffer_output (o, expansion, strlen (expansion));
+
+        free (expansion);
+      }
+
+    return o;
+}
+
+#endif /* CONFIG_WITH_IF_CONDITIONALS */
 
 #ifdef CONFIG_WITH_STACK
@@ -3108 +3146 @@
   struct variable *stack_var;
   const char *stack = argv[0];
-  const int return_item = argv[0][sizeof("stack-pop") - 1] == '\0';
 
   stack_var = lookup_variable (stack, strlen (stack) );
@@ -3959 +3996 @@
   { STRING_SIZE_TUPLE("which"),         0,  0,  1,  func_which},
 #endif
+#ifdef CONFIG_WITH_IF_CONDITIONALS
+  { STRING_SIZE_TUPLE("expr"),          1,  1,  0,  func_expr},
+  { STRING_SIZE_TUPLE("if-expr"),       2,  3,  0,  func_if_expr},
+#endif
 #ifdef CONFIG_WITH_STACK
   { STRING_SIZE_TUPLE("stack-push"),    2,  2,  1,  func_stack_push},

trunk/src/kmk/testcase-ifcond.kmk

@@ -26 +26 @@
 
 
-#DEPTH = ../..
-#include $(PATH_KBUILD)/header.kmk
+DEPTH = ../..
+include $(KBUILD_PATH)/header.kmk
 
 ifeq (1,0)
@@ -223 +223 @@
 # target()
 #
+if 0
 trg_deps_only: foobar
 trg_with_cmds: foobar
@@ -230 +231 @@
 $(warning works)
 else
-$(error works)
+$(error target)
 endif
 
 if target trg_deps_only
-$(error works)
+$(error target)
 else
 $(warning works)
@@ -240 +241 @@
 
 if target foobar
-$(error works)
-else
-$(warning works)
-endif
+$(error target)
+else
+$(warning works)
+endif
+endif 
 
 
@@ -255 +257 @@
 $(warning works)
 else
-$(error works)
+$(error )
 endif
 
@@ -261 +263 @@
 $(warning works)
 else
-$(error works)
+$(error )
 endif
 
@@ -267 +269 @@
 $(warning works)
 else
-$(error works)
+$(error )
 endif
 
 if defined (var_not_defined)
-$(error works)
-else
-$(warning works)
+$(error )
+else
+$(warning works)
+endif
+
+
+#
+# Quick check of $(if-expr ) and $(expr ).
+#
+ifeq ($(if-expr 0 || 2,42,500),42)
+$(warning if-expr test 1 succeeded)
+else
+$(error )
+endif
+
+ifeq ($(if-expr 5+3 == 231,42,500),42)
+$(error )
+else
+$(warning if-expr test 2 succeeded)
+endif
+
+ifeq ($(expr 5+3),8)
+$(warning expr test 1 succeeded)
+else
+$(error expr:$(expr 5+3) expected 8)
+endif
+
+ifeq ($(expr 25*25),625)
+$(warning expr test 2 succeeded)
+else
+$(error expr:$(expr 25*25) expected 625)
+endif
+
+ifeq ($(expr 100/3),3)
+$(error )
+else
+$(warning expr test 3 succeeded)
 endif