Changeset 17289 in vbox for trunk/src

Timestamp:

Mar 3, 2009 2:57:16 PM (16 years ago)

Author:

vboxsync

Message:

PGMAllBth.h: Fixed wrong HCPhys mask in EPT mode (EPT_PTE_PG_MASK=X86_PTE_PAE_PG_MASK_FULL, while we must use X86_PTE_PAE_PG_MASK against PGMPAGE::HCPhys, which omits bits 48 thru 51). Could in theory cause these bits to be wrong, although I'm not so sure intel cares.

File:

• trunk/src/VBox/VMM/VMMAll/PGMAllBth.h (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/PGMAllBth.h

@@ -1479 +1479 @@
                 {
 #if PGM_SHW_TYPE == PGM_TYPE_EPT
-                    PteDst.u             = (HCPhys & EPT_PTE_PG_MASK);
+                    PteDst.u             = PGM_PAGE_GET_HCPHYS(pPage);
                     PteDst.n.u1Present   = 1;
                     PteDst.n.u1Execute   = 1;
@@ -1527 +1527 @@
                     STAM_COUNTER_INC(&pVM->pgm.s.CTX_MID_Z(Stat,DirtyPageSkipped));
 #if PGM_SHW_TYPE == PGM_TYPE_EPT
-                    PteDst.u             = (HCPhys & EPT_PTE_PG_MASK);
+                    PteDst.u             = PGM_PAGE_GET_HCPHYS(pPage);
                     PteDst.n.u1Present   = 1;
                     PteDst.n.u1Write     = 1;