Changeset 17319 in vbox for trunk/src/VBox/Runtime

Timestamp:

Mar 4, 2009 3:18:37 AM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

43691

Message:

IPRT: Added RTGETOPT_REQ_IPV4ADDR to RTGetOpt.

Location:

trunk/src/VBox/Runtime

Files:

• common/misc/getopt.cpp (modified) (3 diffs)
• testcase/tstGetOpt.cpp (modified) (4 diffs)

trunk/src/VBox/Runtime/common/misc/getopt.cpp

@@ -32 +32 @@
 *   Header Files                                                               *
 *******************************************************************************/
+#include <iprt/net.h>
 #include <iprt/getopt.h>
 #include <iprt/err.h>
@@ -64 +65 @@
     /** @todo Add an flag for sorting the arguments so that all the options comes
      *        first. */
+    return VINF_SUCCESS;
+}
+
+
+/**
+ * Converts an stringified IPv4 address into the RTNETADDRIPV4 representation.
+ *
+ * This should be move to some generic part of the runtime.
+ *
+ * @returns VINF_SUCCESS on success, VERR_GETOPT_INVALID_ARGUMENT_FORMAT on
+ *          failure.
+ *
+ * @param   pszValue        The value to convert.
+ * @param   pAddr           Where to store the result.
+ */
+static int rtgetoptConvertIPv4Addr(const char *pszValue, PRTNETADDRIPV4 pAddr)
+{
+    char *pszNext;
+    int rc = RTStrToUInt8Ex(RTStrStripL(pszValue), &pszNext, 10, &pAddr->au8[0]);
+    if (rc != VINF_SUCCESS && rc != VWRN_TRAILING_CHARS)
+        return VERR_GETOPT_INVALID_ARGUMENT_FORMAT;
+    if (*pszNext++ != '.')
+        return VERR_GETOPT_INVALID_ARGUMENT_FORMAT;
+
+    rc = RTStrToUInt8Ex(pszNext, &pszNext, 10, &pAddr->au8[1]);
+    if (rc != VINF_SUCCESS && rc != VWRN_TRAILING_CHARS)
+        return VERR_GETOPT_INVALID_ARGUMENT_FORMAT;
+    if (*pszNext++ != '.')
+        return VERR_GETOPT_INVALID_ARGUMENT_FORMAT;
+
+    rc = RTStrToUInt8Ex(pszNext, &pszNext, 10, &pAddr->au8[2]);
+    if (rc != VINF_SUCCESS && rc != VWRN_TRAILING_CHARS)
+        return VERR_GETOPT_INVALID_ARGUMENT_FORMAT;
+    if (*pszNext++ != '.')
+        return VERR_GETOPT_INVALID_ARGUMENT_FORMAT;
+
+    rc = RTStrToUInt8Ex(pszNext, &pszNext, 10, &pAddr->au8[3]);
+    if (rc != VINF_SUCCESS && rc != VWRN_TRAILING_SPACES)
+        return VERR_GETOPT_INVALID_ARGUMENT_FORMAT;
+    pszNext = RTStrStripL(pszNext);
+    if (*pszNext)
+        return VERR_GETOPT_INVALID_ARGUMENT_FORMAT;
+
     return VINF_SUCCESS;
 }
@@ -315 +359 @@
                 MY_BASE_INT_CASE(RTGETOPT_REQ_UINT32 | RTGETOPT_FLAG_OCT, uint32_t, u,   RTStrToUInt32Full, 8)
                 MY_BASE_INT_CASE(RTGETOPT_REQ_UINT64 | RTGETOPT_FLAG_OCT, uint64_t, u,   RTStrToUInt64Full, 8)
+
 #undef MY_INT_CASE
 #undef MY_BASE_INT_CASE
+
+                case RTGETOPT_REQ_IPV4ADDR:
+                {
+                    RTNETADDRIPV4 Addr;
+                    if (rtgetoptConvertIPv4Addr(pszValue, &Addr) != VINF_SUCCESS)
+                        return VERR_GETOPT_INVALID_ARGUMENT_FORMAT;
+                    pValueUnion->IPv4Addr = Addr;
+                    break;
+                }
 
                 default:

trunk/src/VBox/Runtime/testcase/tstGetOpt.cpp

@@ -30 +30 @@
 
 
+/*******************************************************************************
+*   Header Files                                                               *
+*******************************************************************************/
+#include <iprt/net.h>
 #include <iprt/getopt.h>
 #include <iprt/stream.h>
@@ -83 +87 @@
         { "nodash",             387, RTGETOPT_REQ_NOTHING },
         { "nodashval",          388, RTGETOPT_REQ_STRING },
+        { "--gateway",          'g', RTGETOPT_REQ_IPV4ADDR },
     };
 
@@ -118 +123 @@
 
         "-vqi999",
+
+        "-g192.168.1.1",
         NULL
     };
@@ -191 +198 @@
     CHECK(Val.i32 == 999);
 
+    /* IPv4 */
+    CHECK_GETOPT(RTGetOpt(&GetState, &Val), 'g', 1);
+    CHECK(Val.IPv4Addr.u == RT_H2N_U32_C(RT_BSWAP_U32_C(RT_MAKE_U32_FROM_U8(192,168,1,1))));
+
     /* the end */
     CHECK_GETOPT(RTGetOpt(&GetState, &Val), 0, 0);