Changeset 17403 in vbox for trunk

Timestamp:

Mar 5, 2009 2:49:41 PM (16 years ago)

Author:

vboxsync

Message:

VBoxNetDHCP: fixes and logging.

Location:

trunk/src/VBox/NetworkServices

Files:

• DHCP/VBoxNetDHCP.cpp (modified) (17 diffs)
• UDPLib/VBoxNetUDP.cpp (modified) (1 diff)

trunk/src/VBox/NetworkServices/DHCP/VBoxNetDHCP.cpp

@@ -201 +201 @@
     int                 run(void);
 
-    static const char  *dhcpMsgName(uint8_t MsgType);
-
 protected:
-    int             addConfig(VBoxNetDhcpCfg *pCfg);
-    bool            handleDhcpMsg(uint8_t uMsgType, PCRTNETBOOTP pDhcpMsg, size_t cb);
-
-    inline void     debugPrint( int32_t iMinLevel, bool fMsg,  const char *pszFmt, ...) const;
-    void            debugPrintV(int32_t iMinLevel, bool fMsg,  const char *pszFmt, va_list va) const;
+    int                 addConfig(VBoxNetDhcpCfg *pCfg);
+    bool                handleDhcpMsg(uint8_t uMsgType, PCRTNETBOOTP pDhcpMsg, size_t cb);
+
+    inline void         debugPrint( int32_t iMinLevel, bool fMsg,  const char *pszFmt, ...) const;
+    void                debugPrintV(int32_t iMinLevel, bool fMsg,  const char *pszFmt, va_list va) const;
+    static const char  *debugDhcpName(uint8_t uMsgType);
 
 protected:
@@ -217 +216 @@
     RTMAC               m_MacAddress;
     RTNETADDRIPV4       m_IpAddress;
-    int32_t             m_cVerbosity;
     /** @} */
 
@@ -235 +233 @@
     /** @} */
 
-    /** @name The current packet (for debugPrint)
+    /** @name Debug stuff
      * @{  */
+    int32_t             m_cVerbosity;
     uint8_t             m_uCurMsgType;
     uint16_t            m_cbCurMsg;
@@ -274 +273 @@
     m_pIfBuf                = NULL;
 
+    m_cVerbosity            = 0;
     m_uCurMsgType           = UINT8_MAX;
     m_cbCurMsg              = 0;
     m_pCurMsg               = NULL;
     memset(&m_CurHdrs, '\0', sizeof(m_CurHdrs));
-
 
 #if 1 /* while hacking. */
@@ -376 +375 @@
     RTGETOPTSTATE State;
     int rc = RTGetOptInit(&State, argc, argv, &s_aOptionDefs[0], RT_ELEMENTS(s_aOptionDefs), 0, 0);
-    AssertReturn(rc, 49);
+    AssertRCReturn(rc, 49);
 
     VBoxNetDhcpCfg *pCurCfg = NULL;
@@ -494 +493 @@
     {
         m_pSession = NULL;
-        RTStrmPrintf(g_pStdErr, "VBoxNetDHCP: SUPR3Init -> %Rrc\n", rc);
+        RTStrmPrintf(g_pStdErr, "VBoxNetDHCP: SUPR3Init -> %Rrc", rc);
         return 1;
     }
@@ -502 +501 @@
     if (RT_FAILURE(rc))
     {
-        RTStrmPrintf(g_pStdErr, "VBoxNetDHCP: RTPathProgram -> %Rrc\n", rc);
+        RTStrmPrintf(g_pStdErr, "VBoxNetDHCP: RTPathProgram -> %Rrc", rc);
         return 1;
     }
@@ -509 +508 @@
     if (RT_FAILURE(rc))
     {
-        RTStrmPrintf(g_pStdErr, "VBoxNetDHCP: SUPLoadVMM(\"%s\") -> %Rrc\n", szPath, rc);
+        RTStrmPrintf(g_pStdErr, "VBoxNetDHCP: SUPLoadVMM(\"%s\") -> %Rrc", szPath, rc);
         return 1;
     }
@@ -531 +530 @@
      * Issue the request.
      */
-    if (m_cVerbosity >= 2)
-        RTStrmPrintf(g_pStdErr, "VBoxNetDHCP: attempting to open/create network \"%s\"...\n", OpenReq.szNetwork);
+    debugPrint(2, false, "attempting to open/create network \"%s\"...", OpenReq.szNetwork);
     rc = SUPCallVMMR0Ex(NIL_RTR0PTR, VMMR0_DO_INTNET_OPEN, 0, &OpenReq.Hdr);
     if (RT_SUCCESS(rc))
     {
         m_hIf = OpenReq.hIf;
-        if (m_cVerbosity >= 1)
-            RTStrmPrintf(g_pStdErr, "VBoxNetDHCP: successfully opened/created \"%s\" - hIf=%#x\n",
-                         OpenReq.szNetwork, m_hIf);
+        debugPrint(1, false, "successfully opened/created \"%s\" - hIf=%#x", OpenReq.szNetwork, m_hIf);
 
         /*
@@ -554 +550 @@
         {
             PINTNETBUF pBuf = GetRing3BufferReq.pRing3Buf;
-            if (m_cVerbosity >= 1)
-                RTStrmPrintf(g_pStdErr, "VBoxNetDHCP: pBuf=%p cbBuf=%d cbSend=%d cbRecv=%d\n",
-                             pBuf, pBuf->cbBuf, pBuf->cbSend, pBuf->cbRecv);
+            debugPrint(1, false, "pBuf=%p cbBuf=%d cbSend=%d cbRecv=%d",
+                       pBuf, pBuf->cbBuf, pBuf->cbSend, pBuf->cbRecv);
             m_pIfBuf = pBuf;
 
@@ -607 +602 @@
         WaitReq.pSession = m_pSession;
         WaitReq.hIf = m_hIf;
-        WaitReq.cMillies = RT_INDEFINITE_WAIT;
+        WaitReq.cMillies = 2000; /* 2 secs - the sleep is for some reason uninterruptible... */  /** @todo fix interruptability in SrvIntNet! */
         int rc = SUPCallVMMR0Ex(NIL_RTR0PTR, VMMR0_DO_INTNET_IF_WAIT, 0, &WaitReq.Hdr);
         if (RT_FAILURE(rc))
         {
+            if (rc == VERR_TIMEOUT)
+                continue;
             RTStrmPrintf(g_pStdErr, "VBoxNetDHCP: VMMR0_DO_INTNET_IF_WAIT returned %Rrc\n", rc);
             return 1;
@@ -620 +617 @@
         while (INTNETRingGetReadable(pRingBuf) > 0)
         {
-            size_t          cb;
-            void           *pv = VBoxNetUDPMatch(m_pIfBuf, 67 /* bootps */, &m_MacAddress,
-                                                 VBOXNETUDP_MATCH_UNICAST | VBOXNETUDP_MATCH_BROADCAST | VBOXNETUDP_MATCH_CHECKSUM
-                                                 | (m_cVerbosity > 2 ? VBOXNETUDP_MATCH_PRINT_STDERR : 0),
-                                                 &m_CurHdrs, &cb);
+            size_t  cb;
+            void   *pv = VBoxNetUDPMatch(m_pIfBuf, 67 /* bootps */, &m_MacAddress,
+                                         VBOXNETUDP_MATCH_UNICAST | VBOXNETUDP_MATCH_BROADCAST | VBOXNETUDP_MATCH_CHECKSUM
+                                         | (m_cVerbosity > 2 ? VBOXNETUDP_MATCH_PRINT_STDERR : 0),
+                                         &m_CurHdrs, &cb);
             if (pv && cb)
             {
@@ -638 +635 @@
                     m_uCurMsgType = UINT8_MAX;
                 }
-                else if (m_cVerbosity >= 1)
-                    RTStrmPrintf(g_pStdErr, "VBoxNetDHCP: Skipping invalid DHCP packet.\n");
+                else
+                    debugPrint(1, true, "VBoxNetDHCP: Skipping invalid DHCP packet.\n");
 
                 m_pCurMsg = NULL;
@@ -664 +661 @@
 bool VBoxNetDhcp::handleDhcpMsg(uint8_t uMsgType, PCRTNETBOOTP pDhcpMsg, size_t cb)
 {
+    debugPrint(0, true, "todo");
     return false;
 }
@@ -678 +676 @@
 inline void VBoxNetDhcp::debugPrint(int32_t iMinLevel, bool fMsg, const char *pszFmt, ...) const
 {
-    if (iMinLevel >= m_cVerbosity)
+    if (iMinLevel <= m_cVerbosity)
     {
         va_list va;
@@ -698 +696 @@
 void VBoxNetDhcp::debugPrintV(int iMinLevel, bool fMsg, const char *pszFmt, va_list va) const
 {
-    if (iMinLevel >= m_cVerbosity)
+    if (iMinLevel <= m_cVerbosity)
     {
         va_list vaCopy;                 /* This dude is *very* special, thus the copy. */
@@ -709 +707 @@
             &&  m_pCurMsg)
         {
-            if (m_uCurMsgType != UINT8_MAX)
-            {
-//                const char *pszMsg = dhcpMsgName(m_uCurMsgType);
-//                RTStrmPrintf(g_pStdErr, "VBoxNetDHCP: debug: \n",
-//                                //m_pCurMsg->bp_chaddr
-            }
-            else
-            {
-            }
+            const char *pszMsg = m_uCurMsgType != UINT8_MAX ? debugDhcpName(m_uCurMsgType) : "";
+            RTStrmPrintf(g_pStdErr, "VBoxNetDHCP: debug: %8s chaddr=%.6Rhxs ciaddr=%d.%d.%d.%d yiaddr=%d.%d.%d.%d siaddr=%d.%d.%d.%d\n",
+                         pszMsg,
+                         &m_pCurMsg->bp_chaddr,
+                         m_pCurMsg->bp_ciaddr.au8[0], m_pCurMsg->bp_ciaddr.au8[1], m_pCurMsg->bp_ciaddr.au8[2], m_pCurMsg->bp_ciaddr.au8[3],
+                         m_pCurMsg->bp_yiaddr.au8[0], m_pCurMsg->bp_yiaddr.au8[1], m_pCurMsg->bp_yiaddr.au8[2], m_pCurMsg->bp_yiaddr.au8[3],
+                         m_pCurMsg->bp_siaddr.au8[0], m_pCurMsg->bp_siaddr.au8[1], m_pCurMsg->bp_siaddr.au8[2], m_pCurMsg->bp_siaddr.au8[3]);
         }
+    }
+}
+
+
+/**
+ * Gets the name of given DHCP message type.
+ *
+ * @returns Readonly name.
+ * @param   uMsgType        The message number.
+ */
+/* static */ const char *VBoxNetDhcp::debugDhcpName(uint8_t uMsgType)
+{
+    switch (uMsgType)
+    {
+        case 0:                         return "MT_00";
+        case RTNET_DHCP_MT_DISCOVER:    return "DISCOVER";
+        case RTNET_DHCP_MT_OFFER:       return "OFFER";
+        case RTNET_DHCP_MT_REQUEST:     return "REQUEST";
+        case RTNET_DHCP_MT_DECLINE:     return "DECLINE";
+        case RTNET_DHCP_MT_ACK:         return "ACK";
+        case RTNET_DHCP_MT_NAC:         return "NAC";
+        case RTNET_DHCP_MT_RELEASE:     return "RELEASE";
+        case RTNET_DHCP_MT_INFORM:      return "INFORM";
+        case 9:                         return "MT_09";
+        case 10:                        return "MT_0a";
+        case 11:                        return "MT_0b";
+        case 12:                        return "MT_0c";
+        case 13:                        return "MT_0d";
+        case 14:                        return "MT_0e";
+        case 15:                        return "MT_0f";
+        case 16:                        return "MT_10";
+        case 17:                        return "MT_11";
+        case 18:                        return "MT_12";
+        case 19:                        return "MT_13";
+        case UINT8_MAX:                 return "MT_ff";
+        default:                        return "UNKNOWN";
     }
 }

trunk/src/VBox/NetworkServices/UDPLib/VBoxNetUDP.cpp

@@ -114 +114 @@
     /* Valid IPv4 header? */
     size_t const offIpHdr = (uintptr_t)pIpHdr - (uintptr_t)pEthHdr;
-    if (!RTNetIPv4IsHdrValid(pIpHdr, cbFrame, cbFrame - offIpHdr))
+    if (!RTNetIPv4IsHdrValid(pIpHdr, cbFrame - offIpHdr, cbFrame - offIpHdr))
         return NULL;