Changeset 17465 in vbox

Timestamp:

Mar 6, 2009 1:09:17 PM (16 years ago)

Author:

vboxsync

Message:

Removed unused return code

Location:

trunk

Files:

• include/VBox/pgm.h (modified) (1 diff)
• src/VBox/VMM/VMMAll/PGMAll.cpp (modified) (4 diffs)
• src/VBox/VMM/VMMAll/PGMAllPhys.cpp (modified) (2 diffs)

trunk/include/VBox/pgm.h

@@ -432 +432 @@
 # ifdef IN_RC
 VMMDECL(int)        PGMDynMapHCPage(PVM pVM, RTHCPHYS HCPhys, void **ppv);
-VMMDECL(int)        PGMDynLockHCPage(PVM pVM, RCPTRTYPE(uint8_t *) GCPage);
-VMMDECL(int)        PGMDynUnlockHCPage(PVM pVM, RCPTRTYPE(uint8_t *) GCPage);
+VMMDECL(void)       PGMDynLockHCPage(PVM pVM, RCPTRTYPE(uint8_t *) GCPage);
+VMMDECL(void)       PGMDynUnlockHCPage(PVM pVM, RCPTRTYPE(uint8_t *) GCPage);
 #  ifdef VBOX_STRICT
 VMMDECL(void)       PGMDynCheckLocks(PVM pVM);

trunk/src/VBox/VMM/VMMAll/PGMAll.cpp

@@ -2299 +2299 @@
  * Temporarily lock a dynamic page to prevent it from being reused.
  *
- * @returns VINF_SUCCESS, will bail out to ring-3 on failure.
  * @param   pVM         VM handle.
  * @param   GCPage      GC address of page
  */
-VMMDECL(int) PGMDynLockHCPage(PVM pVM, RCPTRTYPE(uint8_t *) GCPage)
+VMMDECL(void) PGMDynLockHCPage(PVM pVM, RCPTRTYPE(uint8_t *) GCPage)
 {
     unsigned iPage;
@@ -2310 +2309 @@
     iPage = ((uintptr_t)(GCPage - pVM->pgm.s.pbDynPageMapBaseGC)) >> PAGE_SHIFT;
     ASMAtomicIncU32(&pVM->pgm.s.aLockedDynPageMapCache[iPage]);
-    return VINF_SUCCESS;
 }
 
@@ -2317 +2315 @@
  * Unlock a dynamic page
  *
- * @returns VINF_SUCCESS, will bail out to ring-3 on failure.
  * @param   pVM         VM handle.
  * @param   GCPage      GC address of page
  */
-VMMDECL(int) PGMDynUnlockHCPage(PVM pVM, RCPTRTYPE(uint8_t *) GCPage)
+VMMDECL(void) PGMDynUnlockHCPage(PVM pVM, RCPTRTYPE(uint8_t *) GCPage)
 {
     unsigned iPage;
@@ -2331 +2328 @@
     Assert(pVM->pgm.s.aLockedDynPageMapCache[iPage]);
     ASMAtomicDecU32(&pVM->pgm.s.aLockedDynPageMapCache[iPage]);
-    return VINF_SUCCESS;
 }
 

trunk/src/VBox/VMM/VMMAll/PGMAllPhys.cpp

@@ -858 +858 @@
 int pgmPhysGCPhys2CCPtrInternalReadOnly(PVM pVM, PPGMPAGE pPage, RTGCPHYS GCPhys, const void **ppv)
 {
-    int rc;
     AssertReturn(pPage, VERR_INTERNAL_ERROR);
     Assert(PDMCritSectIsOwner(&pVM->pgm.s.CritSect) || VM_IS_EMT(pVM));
@@ -870 +869 @@
 #else
     PPGMPAGEMAPTLBE pTlbe;
-    rc = pgmPhysPageQueryTlbeWithPage(&pVM->pgm.s, pPage, GCPhys, &pTlbe);
+    int rc = pgmPhysPageQueryTlbeWithPage(&pVM->pgm.s, pPage, GCPhys, &pTlbe);
     if (RT_FAILURE(rc))
         return rc;