Changeset 17531 in vbox

Timestamp:

Mar 8, 2009 2:58:03 AM (16 years ago)

Author:

vboxsync

Message:

emInterpretStosWD: don't use PGMPhysWriteGCPtr but emRamWrite (new phys code only). I'd missed this case and it hit when booting windows with additions.

File:

• trunk/src/VBox/VMM/VMMAll/EMAll.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMAll/EMAll.cpp

@@ -1342 +1342 @@
         LogFlow(("emInterpretStosWD dest=%04X:%RGv (%RGv) cbSize=%d\n", pRegFrame->es, GCOffset, GCDest, cbSize));
 
+#ifdef VBOX_WITH_NEW_PHYS_CODE
+        rc = emRamWrite(pVM, pRegFrame, GCDest, &pRegFrame->rax, cbSize);
+#else
         rc = PGMPhysWriteGCPtr(pVM, GCDest, &pRegFrame->rax, cbSize);
+#endif
         if (RT_FAILURE(rc))
             return VERR_EM_INTERPRETER;
@@ -1370 +1374 @@
             return VINF_SUCCESS;
 
-        /* Do *not* try emulate cross page stuff here, this also fends off big copies which
-           would kill PGMR0DynMap. */
+        /*
+         * Do *not* try emulate cross page stuff here because we don't know what might
+         * be waiting for us on the subsequent pages. The caller has only asked us to
+         * ignore access handlers fro the current page.
+         * This also fends off big stores which would quickly kill PGMR0DynMap.
+         */
         if (    cbSize > PAGE_SIZE
             ||  cTransfers > PAGE_SIZE
@@ -1395 +1403 @@
         while (cTransfers)
         {
+#ifdef VBOX_WITH_NEW_PHYS_CODE
+            rc = emRamWrite(pVM, pRegFrame, GCDest, &pRegFrame->rax, cbSize);
+#else
             rc = PGMPhysWriteGCPtr(pVM, GCDest, &pRegFrame->rax, cbSize);
+#endif
             if (RT_FAILURE(rc))
             {