Changeset 1755 in vbox for trunk/src/VBox

Timestamp:

Mar 28, 2007 8:52:16 AM (18 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

19923

Message:

updated logging

File:

• trunk/src/VBox/Devices/Serial/DevSerial.cpp (modified) (6 diffs)

trunk/src/VBox/Devices/Serial/DevSerial.cpp

@@ -193 +193 @@
     }
     if (s->iir != UART_IIR_NO_INT) {
+        Log(("serial_update_irq %d 1\n", s->irq));
 #ifdef VBOX_SERIAL_PCI
         PDMDevHlpPCISetIrqNoWait(CTXSUFF(s->pDevIns), 0, 1);
@@ -199 +200 @@
 #endif /* !VBOX_SERIAL_PCI */
     } else {
+        Log(("serial_update_irq %d 0\n", s->irq));
 #ifdef VBOX_SERIAL_PCI
         PDMDevHlpPCISetIrqNoWait(CTXSUFF(s->pDevIns), 0, 0);
@@ -255 +257 @@
              * bits/line until the character is actually written). This way
              * EMT wouldn't block for writes taking longer than normal. */
-            if (s->pDrvChar)
+            if (RT_LIKELY(s->pDrvChar))
             {
+                Log(("serial_io_port_write: write 0x%X\n", ch));
                 int rc = s->pDrvChar->pfnWrite(s->pDrvChar, &ch, 1);
                 AssertRC(rc);
@@ -323 +326 @@
             *pRC = VINF_IOM_HC_IOPORT_READ;
 #else
+            Log(("serial_io_port_read: read 0x%X\n", s->rbr));
             ret = s->rbr;
             s->lsr &= ~(UART_LSR_DR | UART_LSR_BI);
@@ -434 +438 @@
         if (rc == VINF_SUCCESS)
         {
-            Log(("%s: port %#06x val %#04x\n", __FUNCTION__, Port, u32));
+            Log2(("%s: port %#06x val %#04x\n", __FUNCTION__, Port, u32));
             rc = serial_ioport_write (pData, Port, u32);
             PDMCritSectLeave(&pData->CritSect);
@@ -468 +472 @@
         {
             *pu32 = serial_ioport_read (pData, Port, &rc);
-            Log(("%s: port %#06x val %#04x\n", __FUNCTION__, Port, *pu32));
+            Log2(("%s: port %#06x val %#04x\n", __FUNCTION__, Port, *pu32));
             PDMCritSectLeave(&pData->CritSect);
         }