Changeset 17929 in vbox

Timestamp:

Mar 16, 2009 1:09:36 PM (16 years ago)

Author:

vboxsync

Message:

Main: enabled -Wunused; fixed some warnings

Location:

trunk/src/VBox/Main

Files:

• ApplianceImpl.cpp (modified) (2 diffs)
• Makefile.kmk (modified) (1 diff)
• VirtualBoxImpl.cpp (modified) (1 diff)
• generic/NetIf-generic.cpp (modified) (3 diffs)
• linux/HostHardwareLinux.cpp (modified) (10 diffs)
• xpcom/server.cpp (modified) (1 diff)

trunk/src/VBox/Main/ApplianceImpl.cpp

@@ -3199 +3199 @@
                                                       ComSafeArrayIn(IN_BSTR, argExtraConfigValues))
 {
+    NOREF(aEnabledSize);
+
+    CheckComArgSafeArrayNotNull(aEnabled);
     CheckComArgSafeArrayNotNull(argVboxValues);
     CheckComArgSafeArrayNotNull(argExtraConfigValues);
@@ -3492 +3495 @@
                                    strVbox);
             }
-            else 
+            else
                 throw rc;
         }

trunk/src/VBox/Main/Makefile.kmk

@@ -199 +199 @@
         $(if $(VBOX_WITH_DBUS),VBOX_WITH_DBUS,) \
         $(if $(VBOX_USB_WITH_SYSFS),VBOX_USB_WITH_SYSFS,)
+
+VBoxSVC_CXXFLAGS = $(filter-out -Wno-unused,$(TEMPLATE_VBOXMAINEXE_CXXFLAGS))
 
 ifdef VBOX_WITH_USB

trunk/src/VBox/Main/VirtualBoxImpl.cpp

@@ -717 +717 @@
 VirtualBox::COMGETTER(SharedFolders) (ComSafeArrayOut (ISharedFolder *, aSharedFolders))
 {
+    NOREF(aSharedFoldersSize);
+
     CheckComArgOutSafeArrayPointerValid(aSharedFolders);
 

trunk/src/VBox/Main/generic/NetIf-generic.cpp

@@ -78 +78 @@
 }
 
-int NetIfEnableStaticIpConfig(VirtualBox *vBox, HostNetworkInterface * pIf, ULONG ip, ULONG mask)
+int NetIfEnableStaticIpConfig(VirtualBox * /* vBox */, HostNetworkInterface * pIf, ULONG ip, ULONG mask)
 {
     char szAddress[16]; /* 4*3 + 3*1 + 1 */
@@ -91 +91 @@
 }
 
-int NetIfEnableStaticIpConfigV6(VirtualBox *vBox, HostNetworkInterface * pIf, IN_BSTR aIPV6Address, ULONG aIPV6MaskPrefixLength)
+int NetIfEnableStaticIpConfigV6(VirtualBox * /* vBox */, HostNetworkInterface * pIf, IN_BSTR aIPV6Address, ULONG aIPV6MaskPrefixLength)
 {
     char szAddress[5*8 + 1 + 5 + 1];
@@ -99 +99 @@
 }
 
-int NetIfEnableDynamicIpConfig(VirtualBox *vBox, HostNetworkInterface * pIf)
+int NetIfEnableDynamicIpConfig(VirtualBox * /* vBox */, HostNetworkInterface * /* pIf */)
 {
     return VERR_NOT_IMPLEMENTED;
 }
 
-int NetIfCreateHostOnlyNetworkInterface (VirtualBox *pVbox, IHostNetworkInterface **aHostNetworkInterface, IProgress **aProgress)
+int NetIfCreateHostOnlyNetworkInterface (VirtualBox * /* pVbox */, IHostNetworkInterface ** /* aHostNetworkInterface */, IProgress ** /* aProgress */)
 {
     return VERR_NOT_IMPLEMENTED;
 }
 
-int NetIfRemoveHostOnlyNetworkInterface (VirtualBox *pVbox, IN_GUID aId, IHostNetworkInterface **aHostNetworkInterface, IProgress **aProgress)
+int NetIfRemoveHostOnlyNetworkInterface (VirtualBox * /* pVbox */, IN_GUID /* aId */, IHostNetworkInterface ** /* aHostNetworkInterface */, IProgress ** /* aProgress */)
 {
     return VERR_NOT_IMPLEMENTED;
 }
 
-int NetIfGetConfig(HostNetworkInterface * pIf, NETIFINFO *)
+int NetIfGetConfig(HostNetworkInterface * /* pIf */, NETIFINFO *)
 {
     return VERR_NOT_IMPLEMENTED;
 }
 
-int NetIfDhcpRediscover(VirtualBox *pVbox, HostNetworkInterface * pIf)
+int NetIfDhcpRediscover(VirtualBox * /* pVbox */, HostNetworkInterface * /* pIf */)
 {
     return VERR_NOT_IMPLEMENTED;

trunk/src/VBox/Main/linux/HostHardwareLinux.cpp

@@ -90 +90 @@
                                      const char *pszKey, const char *pszValue,
                                      RTMemAutoPtr <DBusMessage, VBoxDBusMessageUnref> *pMessage);
+/*
 static int halFindDeviceStringMatchVector (DBusConnection *pConnection,
                                            const char *pszKey,
                                            const char *pszValue,
                                            std::vector<std::string> *pMatches);
+*/
 static int halGetPropertyStrings (DBusConnection *pConnection,
                                   const char *pszUdi, size_t cKeys,
                                   const char **papszKeys, char **papszValues,
                                   RTMemAutoPtr <DBusMessage, VBoxDBusMessageUnref> *pMessage);
+/*
 static int halGetPropertyStringsVector (DBusConnection *pConnection,
                                         const char *pszUdi, size_t cProps,
@@ -103 +106 @@
                                         std::vector<std::string> *pMatches,
                                         bool *pfMatches, bool *pfSuccess);
+*/
 static int getDriveInfoFromHal(DriveInfoList *pList, bool isDVD,
                                bool *pfSuccess);
@@ -632 +636 @@
     if (halSuccess)
     {
-        dbus_bus_add_match (dbusConnection.get(), 
+        dbus_bus_add_match (dbusConnection.get(),
                             "type='signal',"
                             "interface='org.freedesktop.Hal.Manager',"
@@ -680 +684 @@
     if (halSuccess)
     {
-        dbus_bus_add_match (dbusConnection.get(), 
+        dbus_bus_add_match (dbusConnection.get(),
                             "type='signal',"
                             "interface='org.freedesktop.Hal.Manager',"
@@ -708 +712 @@
     autoDBusError dbusError;
 
-    dbus_bus_remove_match (pConnection, 
+    dbus_bus_remove_match (pConnection,
                            "type='signal',"
                            "interface='org.freedesktop.Hal.Manager',"
@@ -730 +734 @@
     autoDBusError dbusError;
 
-    dbus_bus_remove_match (pConnection, 
+    dbus_bus_remove_match (pConnection,
                            "type='signal',"
                            "interface='org.freedesktop.Hal.Manager',"
@@ -925 +929 @@
 
     RTMemAutoPtr <DBusMessage, VBoxDBusMessageUnref> message, reply;
-    DBusMessageIter iterGet, iterProps, iterKey, iterValue;
+    DBusMessageIter iterGet, iterProps;
 
     /* Initialise the return array to NULLs */
@@ -1202 +1206 @@
             USBDeviceInfo info (pszDevice, pszSysfsPath);
             bool ifaceSuccess = true;  /* If we can't get the interfaces, just
-                                        * skip this one device. */            
+                                        * skip this one device. */
             rc = getUSBInterfacesFromHal (&info.mInterfaces, pszUdi, &ifaceSuccess);
             if (RT_SUCCESS(rc) && halSuccess && ifaceSuccess)
@@ -1287 +1291 @@
             USBDeviceInfo info (pszDevice, pszSysfsPath);
             bool ifaceSuccess = false;  /* If we can't get the interfaces, just
-                                         * skip this one device. */            
+                                         * skip this one device. */
             rc = getUSBInterfacesFromHal (&info.mInterfaces, pszSysfsPath,
                                           &ifaceSuccess);
@@ -1411 +1415 @@
  */
 /* static */
-DBusHandlerResult dbusFilterFunction (DBusConnection *pConnection,
+DBusHandlerResult dbusFilterFunction (DBusConnection * /* pConnection */,
                                       DBusMessage *pMessage, void *pvUser)
 {

trunk/src/VBox/Main/xpcom/server.cpp

@@ -774 +774 @@
 };
 
-static void signal_handler (int sig)
+static void signal_handler (int /* sig */)
 {
     if (gEventQ && gKeepRunning)