Changeset 17947 in vbox for trunk/src/VBox/Devices/Storage

Timestamp:

Mar 16, 2009 4:00:37 PM (16 years ago)

Author:

vboxsync

Message:

ATA: create correct header for raw sector, according to the spec, fixed writing behind buffer boundaries.

File:

• trunk/src/VBox/Devices/Storage/DevATA.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Storage/DevATA.cpp

@@ -1757 +1757 @@
                 for (uint32_t i = s->iATAPILBA; i < s->iATAPILBA + cSectors; i++)
                 {
-                    /* sync bytes */
+                    /* Sync bytes, see 4.2.3.8 CD Main Channel Block Formats */
                     *pbBuf++ = 0x00;
-                    memset(pbBuf, 0xff, 11);
-                    pbBuf += 11;
+                    memset(pbBuf, 0xff, 10);
+                    pbBuf += 10;
+                    *pbBuf++ = 0x00;
                     /* MSF */
                     ataLBA2MSF(pbBuf, i);
@@ -1770 +1771 @@
                         break;
                     pbBuf += 2048;
-                    /* ECC */
-                    memset(pbBuf, 0, 288);
-                    pbBuf += 288;
+                    /**
+                     * @todo: maybe compute ECC and parity, layout is:
+                     * 2072 4   EDC
+                     * 2076 172 P parity symbols
+                     * 2248 104 Q parity symbols
+                     */
+                    memset(pbBuf, 0, 280);
+                    pbBuf += 280;
                 }
             }