Changeset 1800 in kBuild for trunk/src/kmk

Timestamp:

Sep 21, 2008 1:43:59 AM (16 years ago)

Author:

bird

Message:

incdep: weeny strcache_add_len optimization.

File:

• trunk/src/kmk/incdep.c (modified) (5 diffs)

trunk/src/kmk/incdep.c

@@ -499 +499 @@
 
   incdep_initialized = 0;
+}
+
+/* A quick wrapper around strcache_add_len which avoid the unnecessary
+   copying of the string in order to terminate it. The incdep buffer is
+   always writable, but the eval function like to use const char to avoid
+   silly mistakes and encourage compiler optimizations. */
+static char *
+incdep_strcache_add_len (const char *str, int len)
+{
+#if 1
+  char *ret;
+  char ch = str[len];
+  ((char *)str)[len] = '\0';
+  ret = strcache_add_len (str, len);
+  ((char *)str)[len] = ch;
+  return ret;
+#else
+  return strcache_add_len (str, len);
+#endif
 }
 
@@ -597 +616 @@
               break;
           }
-          var = strcache_add_len (cur, var_len);
+          var = incdep_strcache_add_len (cur, var_len);
 
           /* find the end of the variable. */
@@ -759 +778 @@
                   break;
                 }
-              var = strcache_add_len (cur, var_len);
+              var = incdep_strcache_add_len (cur, var_len);
 
               /* find the start of the value. */
@@ -882 +901 @@
               filenames = xmalloc (sizeof (struct nameseq));
               memset (filenames, 0, sizeof (*filenames));
-              filenames->name = strcache_add_len (cur, endp - cur);
+              filenames->name = incdep_strcache_add_len (cur, endp - cur);
 
               /* parse any dependencies. */
@@ -921 +940 @@
                   /* add it to the list. */
                   *nextdep = dep = alloc_dep ();
-                  dep->name = strcache_add_len (cur, endp - cur);
+                  dep->name = incdep_strcache_add_len (cur, endp - cur);
                   nextdep = &dep->next;