VirtualBox

Changeset 18143 in vbox for trunk/src/VBox/VMM/VMMAll


Ignore:
Timestamp:
Mar 23, 2009 3:10:24 PM (16 years ago)
Author:
vboxsync
Message:

VMM,Devices: Changed ROM registration and fixed some shadowed ROM issues in the new phys code.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/VBox/VMM/VMMAll/PGMAllPhys.cpp

    r18125 r18143  
    115115            rc = PGMHandlerPhysicalPageTempOff(pVM, pRom->GCPhys, GCPhysFault & X86_PTE_PG_MASK);
    116116            AssertRC(rc);
    117             break; /** @todo Must restart the instruction, not use the interpreter! */
     117            break; /** @todo Must edit the shadow PT and restart the instruction, not use the interpreter! */
    118118
    119119        case PGMROMPROT_READ_ROM_WRITE_RAM:
     
    939939 * @param   ppv         Where to store the address corresponding to GCPhys.
    940940 * @param   pLock       Where to store the lock information that PGMPhysReleasePageMappingLock needs.
    941  * 
    942  * @remarks The caller is responsible for dealing with access handlers. 
    943  * @todo    Add an informational return code for pages with access handlers? 
    944  * 
     941 *
     942 * @remarks The caller is responsible for dealing with access handlers.
     943 * @todo    Add an informational return code for pages with access handlers?
     944 *
    945945 * @remark  Avoid calling this API from within critical sections (other than the
    946946 *          PGM one) because of the deadlock risk. External threads may need to
     
    10471047 * This API should only be used for very short term, as it will consume
    10481048 * scarse resources (R0 and GC) in the mapping cache. When you're done
    1049  * with the page, call PGMPhysReleasePageMappingLock() ASAP to release it. 
    1050  * 
     1049 * with the page, call PGMPhysReleasePageMappingLock() ASAP to release it.
     1050 *
    10511051 * @returns VBox status code.
    10521052 * @retval  VINF_SUCCESS on success.
     
    10591059 * @param   pLock       Where to store the lock information that PGMPhysReleasePageMappingLock needs.
    10601060 *
    1061  * @remarks The caller is responsible for dealing with access handlers. 
    1062  * @todo    Add an informational return code for pages with access handlers? 
    1063  * 
     1061 * @remarks The caller is responsible for dealing with access handlers.
     1062 * @todo    Add an informational return code for pages with access handlers?
     1063 *
    10641064 * @remark  Avoid calling this API from within critical sections (other than
    10651065 *          the PGM one) because of the deadlock risk.
     
    11091109        if (RT_UNLIKELY(PGM_PAGE_IS_MMIO(pPage)))
    11101110            rc = VERR_PGM_PHYS_PAGE_RESERVED;
    1111         else 
     1111        else
    11121112        {
    11131113            /*
Note: See TracChangeset for help on using the changeset viewer.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette