Changeset 18194 in vbox for trunk/src

Timestamp:

Mar 24, 2009 3:04:37 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

44910

Message:

Main: #3727: VBoxManage controlvm dvdattach does not work if the image was attached before.

Location:

trunk/src/VBox/Main

Files:

• DVDDriveImpl.cpp (modified) (4 diffs)
• FloppyDriveImpl.cpp (modified) (4 diffs)

trunk/src/VBox/Main/DVDDriveImpl.cpp

@@ -590 +590 @@
 
         m.rollback();
+        if (!m->image.isNull())
+        {
+            /* Reattach from the old image. */
+            HRESULT rc = m->image->attachTo(mParent->id(), mParent->snapshotId());
+            AssertComRC (rc);
+            if (Global::IsOnline (adep.machineState()))
+            {
+                /* Lock from the old image. */
+                rc = m->image->LockRead (NULL);
+                AssertComRC (rc);
+            }
+        }
     }
 
@@ -609 +621 @@
     AssertComRCReturnVoid (peerCaller.rc());
 
-    /* we need adep for the state check */
-    Machine::AutoAnyStateDependency adep (mParent);
-    AssertComRCReturnVoid (adep.rc());
-
     /* lock both for writing since we modify both (mPeer is "master" so locked
      * first) */
@@ -619 +627 @@
     if (m.isBackedUp())
     {
-        Data *oldData = m.backedUpData();
-
-        if (!oldData->image.isNull() &&
-            !oldData->image.equalsTo (m->image))
-        {
-            /* detach the old image that will go away after commit */
-            oldData->image->detachFrom (mParent->id(), mParent->snapshotId());
-
-            /* unlock the image for reading if the VM is online */
-            if (Global::IsOnline (adep.machineState()))
-            {
-                HRESULT rc = oldData->image->UnlockRead (NULL);
-                AssertComRC (rc);
-            }
-        }
-
         m.commit();
         if (mPeer)
@@ -676 +668 @@
 {
     AssertReturn (isWriteLockOnCurrentThread(), E_FAIL);
+
+    /* we need adep for the state check */
+    Machine::AutoAnyStateDependency adep (mParent);
+    AssertComRCReturn (adep.rc(), false);
+
+    if (!m->image.isNull())
+    {
+        HRESULT rc = m->image->detachFrom (mParent->id(), mParent->snapshotId());
+        AssertComRC (rc);
+        if (Global::IsOnline (adep.machineState()))
+        {
+            rc = m->image->UnlockRead (NULL);
+            AssertComRC (rc);
+        }
+    }
 
     m.backup();

trunk/src/VBox/Main/FloppyDriveImpl.cpp

@@ -597 +597 @@
 
         m.rollback();
+        if (!m->image.isNull())
+        {
+            /* Reattach from the old image. */
+            HRESULT rc = m->image->attachTo(mParent->id(), mParent->snapshotId());
+            AssertComRC (rc);
+            if (Global::IsOnline (adep.machineState()))
+            {
+                /* Lock from the old image. */
+                rc = m->image->LockRead (NULL);
+                AssertComRC (rc);
+            }
+        }
     }
 
@@ -616 +628 @@
     AssertComRCReturnVoid (peerCaller.rc());
 
-    /* we need adep for the state check */
-    Machine::AutoAnyStateDependency adep (mParent);
-    AssertComRCReturnVoid (adep.rc());
-
     /* lock both for writing since we modify both (mPeer is "master" so locked
      * first) */
@@ -626 +634 @@
     if (m.isBackedUp())
     {
-        Data *oldData = m.backedUpData();
-
-        if (!oldData->image.isNull() &&
-            !oldData->image.equalsTo (m->image))
-        {
-            /* detach the old image that will go away after commit */
-            oldData->image->detachFrom (mParent->id(), mParent->snapshotId());
-
-            /* unlock the image for reading if the VM is online */
-            if (Global::IsOnline (adep.machineState()))
-            {
-                HRESULT rc = oldData->image->UnlockRead (NULL);
-                AssertComRC (rc);
-            }
-        }
-
         m.commit();
         if (mPeer)
@@ -681 +673 @@
 {
     AssertReturn (isWriteLockOnCurrentThread(), E_FAIL);
+
+    /* we need adep for the state check */
+    Machine::AutoAnyStateDependency adep (mParent);
+    AssertComRCReturn (adep.rc(), false);
+
+    if (!m->image.isNull())
+    {
+        HRESULT rc = m->image->detachFrom (mParent->id(), mParent->snapshotId());
+        AssertComRC (rc);
+        if (Global::IsOnline (adep.machineState()))
+        {
+            rc = m->image->UnlockRead (NULL);
+            AssertComRC (rc);
+        }
+    }
 
     m.backup();