Changeset 18448 in vbox for trunk/src/VBox/Disassembler

Timestamp:

Mar 28, 2009 3:33:44 AM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

45265

Message:

Disasm.cpp/DbgBytesToString: MSC warnings, optimizations.

File:

• trunk/src/VBox/Disassembler/Disasm.cpp (modified) (1 diff)

trunk/src/VBox/Disassembler/Disasm.cpp

@@ -307 +307 @@
 char *DbgBytesToString(PDISCPUSTATE pCpu, RTUINTPTR pBytes, int size, char *pszOutput)
 {
-    char szByte[4];
-    int len = strlen(pszOutput);
-    int i;
-
-    for(i = len; i < 40; i++)
-    {
-        strcat(pszOutput, " ");
-    }
-    strcat(pszOutput, " [");
-    for(i = 0; i < size; i++)
-    {
-        RTStrPrintf(szByte, sizeof(szByte), "%02X ", DISReadByte(pCpu, pBytes+i));
-        RTStrPrintf(&pszOutput[strlen(pszOutput)], 64, szByte);
-    }
-    len = strlen(pszOutput);
-    pszOutput[len - 1] = 0;  //cut off last space
-
-    strcat(pszOutput, "]");
+    char   *psz = strchr(pszOutput, '\0');
+    size_t  len;
+    int     i;
+
+    for(len = psz - pszOutput; len < 40; len++)
+        *psz++ = ' ';
+    *psz++ = ' ';
+    *psz++ = '[';
+
+    for(i = 0; (int)i < size; i++)
+        psz += RTStrPrintf(psz, 64, "%02X ", DISReadByte(pCpu, pBytes+i));
+
+    psz[-1] = ']';  // replaces space
+
     return pszOutput;
 }